[dm-devel] [PATCH v2 3/6] multipathd: make ev_remove_path return success on path removal

Martin Wilck martin.wilck at suse.com
Thu May 13 20:03:36 UTC 2021


On Thu, 2021-05-13 at 12:23 -0500, Benjamin Marzinski wrote:
> When ev_remove_path() returns success, callers assume that the path
> (and
> possibly the map) has been removed.  When ev_remove_path() returns
> failure, callers assume that the path has not been removed. However,
> the
> path could be removed on both success or failure. This could cause
> callers to dereference the path after it was removed. Change
> ev_remove_path() to return success whenever the path is removed, even
> if
> the map was removed due to a failure when trying to reload it. Found
> by
> coverity.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>

I'd have preferred to to join this with patch no. 6. Anyway:

Reviewed-by: Martin Wilck <mwilck at suse.com>





More information about the dm-devel mailing list