[dm-devel] [PATCH stable] dm ioctl: fix out of bounds array access when no devices
Ard Biesheuvel
ardb at kernel.org
Wed May 19 07:41:24 UTC 2021
From: Mikulas Patocka <mpatocka at redhat.com>
commit 4edbe1d7bcffcd6269f3b5eb63f710393ff2ec7a upstream.
If there are not any dm devices, we need to zero the "dev" argument in
the first structure dm_name_list. However, this can cause out of
bounds write, because the "needed" variable is zero and len may be
less than eight.
Fix this bug by reporting DM_BUFFER_FULL_FLAG if the result buffer is
too small to hold the "nl->dev" value.
Signed-off-by: Mikulas Patocka <mpatocka at redhat.com>
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Cc: stable at vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer at redhat.com>
Signed-off-by: Ard Biesheuvel <ardb at kernel.org>
---
Please apply to 4.4.y and 4.9.y
drivers/md/dm-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 836a2808c0c7..eb2659a12310 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -524,7 +524,7 @@ static int list_devices(struct dm_ioctl *param, size_t param_size)
* Grab our output buffer.
*/
nl = get_result_buffer(param, param_size, &len);
- if (len < needed) {
+ if (len < needed || len < sizeof(nl->dev)) {
param->flags |= DM_BUFFER_FULL_FLAG;
goto out;
}
--
2.20.1
More information about the dm-devel
mailing list