[dm-devel] [PATCH v3 0/4] Add "reconfigure all" multipath command

[Martin Wilck]

On Wed, 2021-11-17 at 18:07 -0600, Benjamin Marzinski wrote:
> This patchset is supposed to replace Martin's
> 
> multipathd: add "force_reconfigure" option
> 
> patch from his uxlsnr overhaul patchset. It also makes the default
> reconfigure be a weak reconfigure, but instead of adding a
> configuration
> option to control this, it adds a new multipathd command,
> "reconfigure all", to do a full reconfigure. The HUP signal is left
> doing only weak reconfigures.
> 
> In order to keep from having two states that are handled nearly
> identically, the code adds an extra variable to track the type of
> configuration that was selected, but this could easily be switch to
> use a new DAEMON_CONFIGURE_ALL state instead.
> 
> The final patch, that added the new command, is meant to apply on top
> of
> Martin's changed client handler code. I can send one that works with
> the
> current client handler code, if people would rather review that.
> 
> Changes from v2 as suggested by Martin Wilck:
> 0003: configure() and enable_delayed_reconfig() directly access
> reload_type, instead of having the value passed in.
> schedule_reconfigure() takes an enum force_reload_types instead of a
> bool
> 0004: Modified to deal with schedule_reconfigure() changes.
> 
> Changes from v1 as suggested by Martin Wilck:
> 
> 0001: update libmultipath.version to handle ABI change in struct config
> 0003: Clarify commit message
> 
> Benjamin Marzinski (4):
>   multipathd: move delayed_reconfig out of struct config
>   multipathd: remove reconfigure from header file.
>   multipathd: pass in the type of reconfigure
>   multipathd: add "reconfigure all" command.
> 
>  libmpathpersist/libmpathpersist.version | 12 ++--
>  libmultipath/config.h                   |  1 -
>  libmultipath/configure.c                |  2 +-
>  libmultipath/libmultipath.version       | 22 +++----
>  multipath/main.c                        |  2 +-
>  multipathd/cli.c                        |  1 +
>  multipathd/cli.h                        |  2 +
>  multipathd/cli_handlers.c               | 12 +++-
>  multipathd/main.c                       | 84 +++++++++++++++----------
>  multipathd/main.h                       |  3 +-
>  multipathd/multipathd.8                 | 10 ++-
>  11 files changed, 88 insertions(+), 63 deletions(-)
> 

For the series:

Reviewed-by: Martin Wilck <mwilck at suse.com>

The fact that this is based on my uxlsnr series and that I'm still
working on the latter has required minor rebasing on my part.

Also, my late ABI check has turned out that my patch "add optional
wakeup functionality to lock.c" was actually a major, not minor, ABI
change (offsets in "struct vectors" changed).

Unless you object, I'll resubmit these, rebased and with the library
versions ultimately fixed, when I submit the uxlsnr series.

Martin