[dm-devel] [PATCH 00/21] multipath-tools: coverity fixes

[Benjamin Marzinski]

On Fri, Nov 19, 2021 at 12:13:17AM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> Hi Christophe, hi Ben,
> 
> I have started a new attempt to fix defects reported by coverity.
> With this set (on top of the previously posted one), and a number
> of false positive classifications, I have been able to bring the
> defect count all the way down to zero.
> 
> Most of these patches fix defects reported by coverity. Some
> fix other things that occured to me while working on this.
> 

With the exception of 0005, 0007 and 0008,

Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> Regards,
> Martin
> 
> Martin Wilck (21):
>   multipath tools: github workflows: add coverity workflow
>   multipathd (coverity): check atexit() return value
>   multipathd (coverity): terminate uxlsnr when polls allocation fails
>   libmultipath: strbuf: add __get_strbuf_buf()
>   libmultipath (coverity): improve input checking in parse_vpd_pg83
>   multipath-tools: add tests for broken VPD page 83
>   libmultipath: use strbuf in parse_vpd_pg83()
>   libmultipath (coverity): fix tainted values in alua_rtpg.c
>   multipath, multipathd: exit if bindings file is broken
>   libmultipath (coverity): silence unchecked return value warning
>   multipath: remove pointless code from getopt processing
>   libmultipath (coverity): set umask before mkstemp
>   multipathd (coverity): simplify set_oom_adj()
>   kpartx: open /dev/loop-control only once
>   kpartx: use opened loop device immediately
>   kpartx: find_unused_loop_device(): add newlines
>   multipathd (coverity): daemonize(): use dup2
>   libmultipath (coverity): avoid sleeping in dm_mapname()
>   libmultipath (coverity): Revert "setup_map: wait for pending path
>     checkers to finish"
>   libmultipath (coverity): check return values in dm_get_multipath()
>   libmultipath: update_pathvec_from_dm: don't force DI_WWID
> 
>  .github/workflows/coverity.yaml       |  51 ++++++
>  kpartx/kpartx.c                       |   4 +-
>  kpartx/lopart.c                       | 100 +++++-----
>  kpartx/lopart.h                       |   3 +-
>  libmultipath/alias.c                  |   4 +
>  libmultipath/configure.c              |  63 +------
>  libmultipath/devmapper.c              |  23 +--
>  libmultipath/discovery.c              | 252 ++++++++++++++------------
>  libmultipath/prioritizers/alua_rtpg.c |  13 +-
>  libmultipath/prioritizers/alua_spc3.h |  30 ++-
>  libmultipath/propsel.c                |   2 +-
>  libmultipath/strbuf.c                 |   5 +
>  libmultipath/strbuf.h                 |  14 ++
>  libmultipath/structs_vec.c            |   7 +-
>  multipath/main.c                      |  13 +-
>  multipathd/main.c                     |  91 ++++------
>  multipathd/uxlsnr.c                   |   1 +
>  tests/vpd.c                           | 108 +++++++++++
>  18 files changed, 456 insertions(+), 328 deletions(-)
>  create mode 100644 .github/workflows/coverity.yaml
> 
> -- 
> 2.33.1