[dm-devel] [PATCH 0/3] block: keep quiesce & unquiesce balanced for scsi/dm

Yi Zhang yi.zhang at redhat.com
Mon Oct 25 01:43:57 UTC 2021


Verified with the blktests srp/, thanks Ming.

Tested-by: Yi Zhang <yi.zhang at redhat.com>

On Thu, Oct 21, 2021 at 11:00 PM Ming Lei <ming.lei at redhat.com> wrote:
>
> Hello Jens,
>
> Recently we merge the patch of e70feb8b3e68 ("blk-mq: support concurrent queue
> quiesce/unquiesce") for fixing race between driver and block layer wrt.
> queue quiesce.
>
> Yi reported that srp/002 is broken with this patch, turns out scsi and
> dm don't keep the two balanced actually.
>
> So fix dm and scsi and make srp/002 pass again.
>
>
> Ming Lei (3):
>   scsi: avoid to quiesce sdev->request_queue two times
>   scsi: make sure that request queue queiesce and unquiesce balanced
>   dm: don't stop request queue after the dm device is suspended
>
>  drivers/md/dm.c            | 10 ------
>  drivers/scsi/scsi_lib.c    | 70 ++++++++++++++++++++++++++------------
>  include/scsi/scsi_device.h |  1 +
>  3 files changed, 49 insertions(+), 32 deletions(-)
>
> --
> 2.31.1
>


-- 
Best Regards,
  Yi Zhang




More information about the dm-devel mailing list