[dm-devel] [PATCH] dm raid: add missed unlock in raid_ctr

dinghao.liu at zju.edu.cn dinghao.liu at zju.edu.cn
Mon Sep 6 02:14:24 UTC 2021


> > On Fri, Sep 3, 2021 at 10:02 AM Dinghao Liu dinghao.liu at zju.edu.cn> wrote:
> > mddev_unlock() is called on all paths after we call mddev_lock_nointr(),
> > except for three error handling paths, which may cause a deadlock. This
> > bug is suggested by a static analysis tool, please advise.
> > Hi,    
> >     
> >     correct, those unlock calls are missing.    
> >
> >     As we are bailing out after md_run() with lock held,     
> >     we can clean the lot of error paths underneath up by jumping to before
> >     md_stop() and add the mddev_unlock upfront it like:    
    
Thanks for your advice! I will fix this and send a new patch soon.

Regards,
Dinghao





More information about the dm-devel mailing list