[dm-devel] [PATCH v2 1/4] blk-crypto-fallback: properly prefix function and struct names
Chaitanya Kulkarni
chaitanyak at nvidia.com
Thu Sep 16 23:07:39 UTC 2021
On 9/16/21 10:22 AM, Eric Biggers wrote:
> External email: Use caution opening links or attachments
>
>
> From: Eric Biggers <ebiggers at google.com>
>
> For clarity, avoid using just the "blk_crypto_" prefix for functions and
> structs that are specific to blk-crypto-fallback. Instead, use
> "blk_crypto_fallback_". Some places already did this, but others
> didn't.
>
> This is also a prerequisite for using "struct blk_crypto_keyslot" to
> mean a generic blk-crypto keyslot (which is what it sounds like).
> Rename the fallback one to "struct blk_crypto_fallback_keyslot".
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Signed-off-by: Eric Biggers <ebiggers at google.com>
Looks good, it might be useful to mention this patch doesn't change
any functionality, not a hard requirement though.
Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
More information about the dm-devel
mailing list