[dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit

[Martin Wilck]

On Fri, 2021-09-24 at 09:34 +0000, Luca BRUNO wrote:
> This aligns 'multipathd' socket and service units, by adding the
> start conditions that are set on the service but not on the socket.
> It should help avoiding situations where the socket unit ends up
> marked as failed after hitting its retry-limit.
> 
> Fixes: https://github.com/opensvc/multipath-tools/issues/15
> Signed-off-by: Luca BRUNO <luca.bruno at coreos.com>
> ---
>  multipathd/multipathd.socket | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git multipathd/multipathd.socket multipathd/multipathd.socket
> index 0ed4a1f7..c777e5e3 100644
> --- multipathd/multipathd.socket
> +++ multipathd/multipathd.socket
> @@ -1,6 +1,9 @@
>  [Unit]
>  Description=multipathd control socket
>  DefaultDependencies=no
> +ConditionKernelCommandLine=!nompath
> +ConditionKernelCommandLine=!multipath=off
> +ConditionVirtualization=!container
>  Before=sockets.target
>  
>  [Socket]

Thanks!

I'll apply this to
https://github.com/openSUSE/multipath-tools/tree/queue

>From there it'll be submitted to the main repo.

Reviewed-by: Martin Wilck <mwilck at suse.com>