[dm-devel] [PATCH v8 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode
Jane Chu
jane.chu at oracle.com
Fri Apr 22 04:15:19 UTC 2022
On 4/20/2022 11:57 PM, Christoph Hellwig wrote:
>> + if (bb->count &&
>> + badblocks_check(bb, sector, num, &first_bad, &num_bad)) {
>
> Weird alignment here, continuing lines for conditionals are aligned
> either after the opening brace:
>
> if (bb->count &&
> badblocks_check(bb, sector, num, &first_bad, &num_bad)) {
>
> or with double tabs. I tend to prefer the version I posted above.
>
> The being said, shouldn't this change even be in this patch and not just
> added once we add actual recovery support?
Right, will move the recovery_write related changes to next patch.
thanks!
-jane
More information about the dm-devel
mailing list