[dm-devel] [PATCH 03/14] dm: refactor dm_split_and_process_bio a bit
Christoph Hellwig
hch at infradead.org
Fri Feb 11 06:52:42 UTC 2022
> + error = __split_and_process_bio(&ci);
> + if (ci.sector_count && !error) {
Maybe turn thisin to
if (error || !ci.sector_count)
goto out;
ci.io->orig_bio = bio_split(bio, bio_sectors(bio) - ci.sector_count,
GFP_NOIO, &md->queue->bio_split);
bio_chain(ci.io->orig_bio, bio);
trace_block_split(ci.io->orig_bio, bio->bi_iter.bi_sector);
submit_bio_noacct(bio);
and remove another layer of indentation uing the existing label?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
More information about the dm-devel
mailing list