[dm-devel] [PATCH] libmultipath: fix printing native nvme multipath topology.

Martin Wilck martin.wilck at suse.com
Wed Feb 16 08:34:41 UTC 2022


On Wed, 2022-02-16 at 00:12 -0600, Benjamin Marzinski wrote:
> Since commit 2f05df4 ("libmultipath: use strbuf in print.c"), when
> multipath prints the topology of native nvme devices, instead of
> printing the multipath device information, it prints "w [G]:d s".
> This
> is because nvme_style() switched from calling snprintf(), which
> supports
> format specifiers, to append_strbuf_str(), which doesn't, while still
> keeping the same string, "%%w [%%G]:%%d %%s". Remove the extra
> percent
> signs, since they don't need to be escaped in append_strbuf_str().
> 
> Fixes: 2f05df4 ("libmultipath: use strbuf in print.c")
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>

Oops, thanks a lot for catching this!

Reviewed-by: Martin Wilck <mwilck at suse.com>





More information about the dm-devel mailing list