[dm-devel] [PATCH] libmultipath: fix find_multipaths_timeout for unknown hardware

Martin Wilck martin.wilck at suse.com
Wed Jul 13 09:20:33 UTC 2022


On Tue, 2022-07-12 at 17:02 -0500, Benjamin Marzinski wrote:
> pp->hwe is now a vector that will always be allocated for all path
> devices. Instead of checking if it is NULL, check if it is empty.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
Reviewed-by: Martin Wilck <mwilck at suse.com>

> ---
>  libmultipath/propsel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
> index 50d0b5c8..f782f251 100644
> --- a/libmultipath/propsel.c
> +++ b/libmultipath/propsel.c
> @@ -1293,7 +1293,7 @@ out:
>          */
>         if (pp->find_multipaths_timeout < 0) {
>                 pp->find_multipaths_timeout = -pp-
> >find_multipaths_timeout;
> -               if (!pp->hwe) {
> +               if (VECTOR_SIZE(pp->hwe) == 0) {
>                         pp->find_multipaths_timeout =
>                                 DEFAULT_UNKNOWN_FIND_MULTIPATHS_TIMEO
> UT;
>                         origin = "(default for unknown hardware)";



More information about the dm-devel mailing list