[dm-devel] [PATCH v2 11/11] multipathd: remove unhelpful startup / shutdown messages

[Benjamin Marzinski]

On Fri, Mar 18, 2022 at 5:33 PM <mwilck at suse.com> wrote:
>
> From: Martin Wilck <mwilck at suse.com>
>
> These messages are noisy in the system log without being actually helpful.

I've actually found the "start up" and "shut down" messages useful a
number of times, for tracking when multipathd starts up and shuts
down. Since people generally run multipathd constantly, they rarely
appear more than a couple of times per boot. I would prefer if they
could stay.  I'm fine with removing the others.

-Ben

> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  multipathd/main.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 4b4fa9c..6e6635b 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2560,7 +2560,6 @@ checkerloop (void *ap)
>         rcu_register_thread();
>         mlockall(MCL_CURRENT | MCL_FUTURE);
>         vecs = (struct vectors *)ap;
> -       condlog(2, "path checkers start up");
>
>         /* Tweak start time for initial path check */
>         get_monotonic_time(&last_time);
> @@ -3241,8 +3240,7 @@ child (__attribute__((unused)) void *param)
>
>         post_config_state(DAEMON_START);
>
> -       condlog(2, "--------start up--------");
> -       condlog(2, "read " DEFAULT_CONFIGFILE);
> +       condlog(3, "read " DEFAULT_CONFIGFILE);
>
>         if (verbosity)
>                 libmp_verbosity = verbosity;
> @@ -3435,7 +3433,6 @@ child (__attribute__((unused)) void *param)
>
>         exit_code = 0;
>  failed:
> -       condlog(2, "--------shut down-------");
>         /* All cleanup is done in the cleanup_child() exit handler */
>         return sd_notify_exit(exit_code);
>  }
> --
> 2.35.1
>