[dm-devel] [PATCH v3 11/12] multipathd: make startup / shutdown messages less noisy

[Benjamin Marzinski]

On Thu, Mar 24, 2022 at 10:19:26PM +0100, mwilck at suse.com wrote:
> From: Martin Wilck <mwilck at suse.com>
> 
> These messages are noisy in the system log without being actually helpful.
> Print the version number on startup.
> 
> Signed-off-by: Martin Wilck <mwilck at suse.com>

Reviewed-by: Benjamin Marzinski <bmarzins at redhat.com>

> ---
>  multipathd/main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 9ef3197..aee0953 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -37,6 +37,7 @@
>  /*
>   * libmultipath
>   */
> +#include "version.h"
>  #include "parser.h"
>  #include "vector.h"
>  #include "config.h"
> @@ -2566,7 +2567,6 @@ checkerloop (void *ap)
>  	rcu_register_thread();
>  	mlockall(MCL_CURRENT | MCL_FUTURE);
>  	vecs = (struct vectors *)ap;
> -	condlog(2, "path checkers start up");
>  
>  	/* Tweak start time for initial path check */
>  	get_monotonic_time(&last_time);
> @@ -3247,8 +3247,8 @@ child (__attribute__((unused)) void *param)
>  
>  	post_config_state(DAEMON_START);
>  
> -	condlog(2, "--------start up--------");
> -	condlog(2, "read " DEFAULT_CONFIGFILE);
> +	condlog(2, "multipathd v%d.%d.%d: start up", MULTIPATH_VERSION(VERSION_CODE));
> +	condlog(3, "read " DEFAULT_CONFIGFILE);
>  
>  	if (verbosity)
>  		libmp_verbosity = verbosity;
> @@ -3441,7 +3441,7 @@ child (__attribute__((unused)) void *param)
>  
>  	exit_code = 0;
>  failed:
> -	condlog(2, "--------shut down-------");
> +	condlog(2, "multipathd: shut down");
>  	/* All cleanup is done in the cleanup_child() exit handler */
>  	return sd_notify_exit(exit_code);
>  }
> -- 
> 2.35.1