[dm-devel] [PATCH 0/7] multipath-tools: fix unit test breakage

mwilck at suse.com mwilck at suse.com
Tue May 3 22:06:39 UTC 2022


From: Martin Wilck <mwilck at suse.com>

Hi Christophe, hi Ben,

The previous patches 

af15832 multipath-tools: make multipath_dir a compiled-in option
1fc7c4d multipath-tools: make config_dir a compiled-in option
21b3d6b multipath-tools: stop supporting getuid_callout

have caused breakage in the unit tests. Not so much because they'd
actually break the tests, but because they broke the compilation and
the search paths for the configuration files (for the former two commits)
and because the hwtable test relied on being able to the retrieve
the now removed "getuid_callout" property from config files.

Fix it. As always, comments welcome.

Regards
Martin

Martin Wilck (7):
  multipath-tools: enable local configdir and plugindir for unit tests
  tests/mpathvalid: fix check for DEFAULT_CONFIG_FILE
  multipath-tools tests: hwtable: adapt after removal of getuid
  tests/hwtable: fix test_regex_2_strings_hwe_dir
  libmultipath: fix valgrind_test
  tests/Makefile: make TESTDIR configurable
  github workflows: foreign.yaml: fix config dir in run environment

 .github/workflows/foreign.yaml |   7 +-
 libmultipath/Makefile          |  24 ++++--
 libmultipath/config.c          |   3 +
 tests/Makefile                 |  12 ++-
 tests/hwtable.c                | 151 ++++++++++++++++-----------------
 tests/mpathvalid.c             |   2 +-
 tests/test-lib.c               |  89 ++++++++++++++-----
 tests/test-lib.h               |   2 +-
 8 files changed, 180 insertions(+), 110 deletions(-)

-- 
2.36.0



More information about the dm-devel mailing list