[dm-devel] [PATCH v2] hex2bin: make the function hex_to_bin constant-time

Linus Torvalds torvalds at linux-foundation.org
Wed May 4 18:00:00 UTC 2022


On Wed, May 4, 2022 at 3:15 AM Jason A. Donenfeld <Jason at zx2c4.com> wrote:
>
> > Alignment? Compiler bug? HW issue?
>
> Probably one of those, yea. Removing the instruction addresses, the only
> difference between the two compiles is: https://xn--4db.cc/Rrn8usaX/diff#line-440

Well, that address doesn't work for me at all. It turns into א.cc.

I'd love to see the compiler problem, since I find those fascinating
(mainly because they scare the hell out of me), but those web
addresses you use are not working for me.

It most definitely looks like an OpenRISC compiler bug - that code
doesn't look like it does anything remotely undefined (and with the
"unsigned char", nothing implementation-defined either).

             Linus



More information about the dm-devel mailing list