<div dir="ltr"><div class="gmail_extra">On Thu, Jun 20, 2013 at 5:59 PM, Alasdair G Kergon <span dir="ltr"><<a href="mailto:agk@redhat.com" target="_blank">agk@redhat.com</a>></span> wrote:<br><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Thu, Jun 20, 2013 at 02:21:00PM -0700, Geremy Condra wrote:<br>
> With this change and config option, dm-verity errors<br>
> will cause uevents to be sent to userspace, notifying<br>
> it that an error has occurred and potentially<br>
> triggering recovery actions.<br>
<br>
</div><div class="im">> +config DM_VERITY_ERROR_NOTIFY<br>
> + tristate "Notify userspace of verity errors through uevents"<br>
> + depends on DM_VERITY && DM_UEVENT<br>
> + ---help---<br>
> + This option instructs dm-verity to send uevents on error.<br>
> +<br>
<br>
</div>Would it cause any problems if we had this feature enabled all the time,<br>
controlled only by DM_UEVENT?<br>
<br>
In other words, if we delete DM_VERITY_ERROR_NOTIFY from the upstream patch?<br></blockquote><div><br></div><div>Assuming nobody currently using DM_UEVENT minds it doesn't cause any problems for me. Any current users object?</div>
<div><br></div><div>Geremy Condra</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Alasdair<br>
<br>
</font></span></blockquote></div><br></div></div>