<div dir="ltr">Applied.<div>Thanks.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 30, 2014 at 10:20 AM, Jose Castillo <span dir="ltr"><<a href="mailto:jcastillo@redhat.com" target="_blank">jcastillo@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If the option "fast_io_fail_tmo" is specified in multipath.conf, without a value, the command 'multipathd reconfigure' segfaults.<br>

With the patch included here, multipathd returns "error parsing config file" and does not segfaults.<br>
<br>
Signed-off-by: Jose Castillo <<a href="mailto:jcastillo@redhat.com">jcastillo@redhat.com</a>><br>
---<br>
 libmultipath/dict.c | 3 +++<br>
 1 file changed, 3 insertions(+)<br>
<br>
diff --git a/libmultipath/dict.c b/libmultipath/dict.c<br>
index 9db4725..91d9b83 100644<br>
--- a/libmultipath/dict.c<br>
+++ b/libmultipath/dict.c<br>
@@ -43,6 +43,9 @@ def_fast_io_fail_handler(vector strvec)<br>
        char * buff;<br>
<br>
        buff = set_value(strvec);<br>
+       if (!buff)<br>
+               return 1;<br>
+<br>
        if (strlen(buff) == 3 && !strcmp(buff, "off"))<br>
                conf->fast_io_fail = MP_FAST_IO_FAIL_OFF;<br>
        else if (sscanf(buff, "%d", &conf->fast_io_fail) != 1 ||<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.0<br>
<br>
--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com">dm-devel@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/dm-devel" target="_blank">https://www.redhat.com/mailman/listinfo/dm-devel</a><br>
</font></span></blockquote></div><br></div>