<div dir="ltr">Applied then.<div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 5:02 PM, Bart Van Assche <span dir="ltr"><<a href="mailto:bart.vanassche@sandisk.com" target="_blank">bart.vanassche@sandisk.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/12/2016 11:33 AM, Xose Vazquez Perez wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 08/12/2016 08:10 PM, Bart Van Assche wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It seems like a patch description that motivates why this change is<br>
</blockquote></blockquote>
>> considered useful is missing completely? Anyway, have you considered<br>
>> to use a name that is consistent by what is expected by automake,<br>
>> namely LDADD (see also <a href="https://www.gnu.org/software/automake/manual/html_node/Linking.html#Linking" rel="noreferrer" target="_blank">https://www.gnu.org/software/a<wbr>utomake/manual/html_node/Linki<wbr>ng.html#Linking</a>)?<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I followed just same rule as in the rest of multipath-tools'<br>
Makefiles. Where it's called "LIBDEPS":<br>
<br>
libmpathpersist/Makefile:LIBDE<wbr>PS +=  -lpthread -ldevmapper -ldl -L$(multipathdir) -lmultipath \<br>
libmultipath/Makefile:          LIBDEPS += -lsystemd<br>
libmultipath/Makefile:          LIBDEPS += -lsystemd-daemon<br>
</blockquote>
<br></span>
Hello Xose,<br>
<br>
Thanks for the clarification. Since LIBDEPS is already used elsewhere in multipath-tools makefiles I'm fine with using that name. I don't think it's worth to rename all uses of LIBDEPS in other Makefiles.<span class="HOEnZb"><font color="#888888"><br>
<br>
Bart.</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com" target="_blank">dm-devel@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer" target="_blank">https://www.redhat.com/mailman<wbr>/listinfo/dm-devel</a><br>
</div></div></blockquote></div><br></div>