<div dir="ltr"><div>This one was not forgotten.</div>I was waiting for follow-ons on the discussion with Bart.<div>Do you have a position on the opportunity to align on the variable name used by autoconf ?</div><div><br></div><div>The other patches of the set are now merged.</div><div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 2:38 PM, Xose Vazquez Perez <span dir="ltr"><<a href="mailto:xose.vazquez@gmail.com" target="_blank">xose.vazquez@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Cc: Christophe Varoqui <<a href="mailto:christophe.varoqui@opensvc.com">christophe.varoqui@opensvc.<wbr>com</a>><br>
Cc: device-mapper development <<a href="mailto:dm-devel@redhat.com">dm-devel@redhat.com</a>><br>
Signed-off-by: Xose Vazquez Perez <<a href="mailto:xose.vazquez@gmail.com">xose.vazquez@gmail.com</a>><br>
---<br>
kpartx/Makefile | 4 ++--<br>
mpathpersist/Makefile | 4 ++--<br>
multipath/Makefile | 4 ++--<br>
multipathd/Makefile | 8 ++++----<br>
4 files changed, 10 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/kpartx/Makefile b/kpartx/Makefile<br>
index 8af0dc6..853288f 100644<br>
--- a/kpartx/Makefile<br>
+++ b/kpartx/Makefile<br>
@@ -5,7 +5,7 @@ include ../Makefile.inc<br>
<br>
CFLAGS += -I. -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64<br>
<br>
-LDFLAGS += -ldevmapper<br>
+LIBDEPS += -ldevmapper<br>
<br>
LIBDM_API_COOKIE = $(shell grep -Ecs '^[a-z]*[[:space:]]+dm_task_<wbr>set_cookie' /usr/include/libdevmapper.h)<br>
<br>
@@ -21,7 +21,7 @@ EXEC = kpartx<br>
all: $(EXEC)<br>
<br>
$(EXEC): $(OBJS)<br>
- $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS)<br>
+ $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)<br>
$(GZIP) $(EXEC).8 > $(EXEC).8.gz<br>
<br>
install: $(EXEC) $(EXEC).8<br>
diff --git a/mpathpersist/Makefile b/mpathpersist/Makefile<br>
index b6ab730..7921619 100644<br>
--- a/mpathpersist/Makefile<br>
+++ b/mpathpersist/Makefile<br>
@@ -2,7 +2,7 @@ include ../Makefile.inc<br>
<br>
CFLAGS += -I$(multipathdir) -I$(mpathpersistdir)<br>
<br>
-LDFLAGS += -lpthread -ldevmapper -L$(mpathpersistdir) -lmpathpersist \<br>
+LIBDEPS += -lpthread -ldevmapper -L$(mpathpersistdir) -lmpathpersist \<br>
-L$(multipathdir) -L$(mpathcmddir) -lmpathcmd -lmultipath -ludev<br>
<br>
EXEC = mpathpersist<br>
@@ -12,7 +12,7 @@ OBJS = main.o<br>
all: $(EXEC)<br>
<br>
$(EXEC): $(OBJS)<br>
- $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS)<br>
+ $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS) $(LIBDEPS)<br>
$(GZIP) $(EXEC).8 > $(EXEC).8.gz<br>
<br>
install:<br>
diff --git a/multipath/Makefile b/multipath/Makefile<br>
index b125ae3..f296add 100644<br>
--- a/multipath/Makefile<br>
+++ b/multipath/Makefile<br>
@@ -5,7 +5,7 @@ include ../Makefile.inc<br>
<br>
CFLAGS += -I$(multipathdir) -I$(mpathcmddir)<br>
<br>
-LDFLAGS += -lpthread -ldevmapper -ldl -L$(multipathdir) -lmultipath -ludev \<br>
+LIBDEPS += -lpthread -ldevmapper -ldl -L$(multipathdir) -lmultipath -ludev \<br>
-L$(mpathcmddir) -lmpathcmd<br>
<br>
EXEC = multipath<br>
@@ -15,7 +15,7 @@ OBJS = main.o<br>
all: $(EXEC)<br>
<br>
$(EXEC): $(OBJS)<br>
- $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS)<br>
+ $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)<br>
$(GZIP) $(EXEC).8 > $(EXEC).8.gz<br>
$(GZIP) $(EXEC).conf.5 > $(EXEC).conf.5.gz<br>
<br>
diff --git a/multipathd/Makefile b/multipathd/Makefile<br>
index 03d7815..8524efa 100644<br>
--- a/multipathd/Makefile<br>
+++ b/multipathd/Makefile<br>
@@ -8,16 +8,16 @@ include ../Makefile.inc<br>
#CFLAGS += -DLOGDBG<br>
CFLAGS += -I$(multipathdir) -I$(mpathpersistdir) -I$(mpathcmddir)<br>
<br>
-LDFLAGS += -ludev -ldl -L$(multipathdir) -lmultipath -L$(mpathpersistdir) \<br>
+LIBDEPS += -ludev -ldl -L$(multipathdir) -lmultipath -L$(mpathpersistdir) \<br>
-lmpathpersist -L$(mpathcmddir) -lmpathcmd -lurcu -lpthread \<br>
-ldevmapper -lreadline<br>
<br>
ifdef SYSTEMD<br>
CFLAGS += -DUSE_SYSTEMD=$(SYSTEMD)<br>
ifeq ($(shell test $(SYSTEMD) -gt 209 && echo 1), 1)<br>
- LDFLAGS += -lsystemd<br>
+ LIBDEPS += -lsystemd<br>
else<br>
- LDFLAGS += -lsystemd-daemon<br>
+ LIBDEPS += -lsystemd-daemon<br>
endif<br>
endif<br>
<br>
@@ -28,7 +28,7 @@ EXEC = multipathd<br>
all : $(EXEC)<br>
<br>
$(EXEC): $(OBJS)<br>
- $(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) -o $(EXEC)<br>
+ $(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) -o $(EXEC) $(LIBDEPS)<br>
$(GZIP) $(EXEC).8 > $(EXEC).8.gz<br>
<br>
install:<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
</font></span></blockquote></div><br></div>