<div dir="ltr">I would merge that too, sure.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 29, 2016 at 5:51 PM, Bart Van Assche <span dir="ltr"><<a href="mailto:bart.vanassche@sandisk.com" target="_blank">bart.vanassche@sandisk.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/29/2016 12:19 AM, Christophe Varoqui wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I think it would be fair to detect the valgrind headers presence in the<br>
Makefile and ifdef the include (else define dummy ANNOTATE_* macros).<br>
<br>
Would you care to prepare that ?<br>
</blockquote>
<br></span>
Hello Christophe,<br>
<br>
How about adding a copy of the valgrind.h and helgrind.h header files to the multipath-tools source tree? This is the approach that is followed by several other projects, e.g. chromium. See also <a href="https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h" rel="noreferrer" target="_blank">https://chromium.googlesource.<wbr>com/chromium/src/base/+/master<wbr>/third_party/valgrind/valgrind<wbr>.h</a>.<br>
<br>
Thanks,<br>
<br>
Bart.<br>
</blockquote></div><br></div>