<div dir="ltr">Merged,<div>Thanks.</div></div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Sep 29, 2016 at 11:28 PM, Bart Van Assche <<a href="mailto:bart.vanassche@sandisk.com" target="_blank">bart.vanassche@sandisk.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Calling pthread_cond_signal() without holding the associated mutex sporadically results in a lost wakeup. Hence call pthread_cond_signal() while holding the mutex used by pthread_cond_wait(). Signed-off-by: Bart Van Assche <<a href="mailto:bart.vanassche@sandisk.com">bart.vanassche@sandisk.com</a>> Cc: Mike Christie <<a href="mailto:mchristi@redhat.com">mchristi@redhat.com</a>> --- libmultipath/checkers/rbd.c | 2 +- libmultipath/checkers/tur.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/checkers/rbd.c b/libmultipath/checkers/rbd.c index 874bcfa..41259c3 100644 --- a/libmultipath/checkers/rbd.c +++ b/libmultipath/checkers/rbd.c @@ -527,8 +527,8 @@ static void *rbd_thread(void *ctx) /* checker done */ pthread_mutex_lock(&ct->lock); ct->state = state; - pthread_mutex_unlock(&ct->lock); pthread_cond_signal(&ct->active); + pthread_mutex_unlock(&ct->lock); condlog(3, "rbd%d thead finished, state %s", ct->rbd_bus_id, checker_state_name(state)); diff --git a/libmultipath/checkers/tur.c b/libmultipath/checkers/tur.c index 8c1f633..94e4190 100644 --- a/libmultipath/checkers/tur.c +++ b/libmultipath/checkers/tur.c @@ -225,8 +225,8 @@ static void *tur_thread(void *ctx) /* TUR checker done */ pthread_mutex_lock(&ct->lock); ct->state = state; - pthread_mutex_unlock(&ct->lock); pthread_cond_signal(&ct->active); + pthread_mutex_unlock(&ct->lock); condlog(3, "%d:%d: tur checker finished, state %s", TUR_DEVT(ct), checker_state_name(state)); -- 2.10.0 </blockquote></div> </div>