<div dir="ltr">Seems right.<div>Merged, with thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 11, 2016 at 8:37 AM, <span dir="ltr"><<a href="mailto:tang.junhui@zte.com.cn" target="_blank">tang.junhui@zte.com.cn</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font size="2">Please have a review</font><font size="2" face="sans-serif">
for this patch, any comment will be highly appreciated.<br>
</font>
<br>
<br>
<br>
<br><font size="1" color="#5f5f5f" face="sans-serif">发件人:
</font><font size="1" face="sans-serif"><a href="mailto:tang.junhui@zte.com.cn" target="_blank">tang.junhui@zte.com.cn</a></font>
<br><font size="1" color="#5f5f5f" face="sans-serif">收件人:
</font><font size="1" face="sans-serif">christophe
varoqui <<a href="mailto:christophe.varoqui@free.fr" target="_blank">christophe.varoqui@free.fr</a>>, <a href="mailto:Chauhan@redhat.com" target="_blank">Chauhan@redhat.com</a>, Vijay <<a href="mailto:Vijay.Chauhan@netapp.com" target="_blank">Vijay.Chauhan@netapp.com</a>>,
Benjamin Marzinski <<a href="mailto:bmarzins@redhat.com" target="_blank">bmarzins@redhat.com</a>>, </font>
<br><font size="1" color="#5f5f5f" face="sans-serif">抄送:
</font><font size="1" face="sans-serif"><a href="mailto:zhang.kai16@zte.com.cn" target="_blank">zhang.kai16@zte.com.cn</a>,
<a href="mailto:dm-devel@redhat.com" target="_blank">dm-devel@redhat.com</a>, "tang.junhui" <<a href="mailto:tang.junhui@zte.com.cn" target="_blank">tang.junhui@zte.com.cn</a>></font>
<br><font size="1" color="#5f5f5f" face="sans-serif">日期:
</font><font size="1" face="sans-serif">2016/09/21
16:54</font>
<br><font size="1" color="#5f5f5f" face="sans-serif">主题:
</font><font size="1" face="sans-serif">[dm-devel] [PATCH]
mpathpersist: memset length is wrong</font>
<br><font size="1" color="#5f5f5f" face="sans-serif">发件人:
</font><font size="1" face="sans-serif"><a href="mailto:dm-devel-bounces@redhat.com" target="_blank">dm-devel-bounces@redhat.com</a></font>
<br>
<hr noshade><div class="HOEnZb"><div class="h5">
<br>
<br>
<br><tt><font size="2">From: "tang.junhui" <<a href="mailto:tang.junhui@zte.com.cn" target="_blank">tang.junhui@zte.com.cn</a>><br>
<br>
variable transportids is cleared by memset() with wrong length MPATH_MX_TIDS,<br>
the length should be MPATH_MX_TIDS*sizeof(struct transportid).<br>
<br>
Signed-off-by: tang.junhui <<a href="mailto:tang.junhui@zte.com.cn" target="_blank">tang.junhui@zte.com.cn</a>><br>
---<br>
mpathpersist/main.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/mpathpersist/main.c b/mpathpersist/main.c<br>
index a55865f..8e8cc35 100644<br>
--- a/mpathpersist/main.c<br>
+++ b/mpathpersist/main.c<br>
@@ -105,7 +105,7 @@ int main (int argc, char * argv[])<br>
<br>
udev
= udev_new();<br>
conf
= mpath_lib_init(udev);<br>
-
memset(transportids,0,MPATH_<wbr>MX_TIDS);<br>
+
memset(transportids, 0, MPATH_MX_TIDS * sizeof(struct transportid));<br>
multipath_conf
= conf;<br>
<br>
while
(1)<br>
-- <br>
2.8.1.windows.1<br>
<br>
--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com" target="_blank">dm-devel@redhat.com</a><br>
</font></tt><a href="https://www.redhat.com/mailman/listinfo/dm-devel" target="_blank"><tt><font size="2">https://www.redhat.com/<wbr>mailman/listinfo/dm-devel</font></tt></a><tt><font size="2"><br>
</font></tt>
<br>
</div></div></blockquote></div><br></div>