<font size=2 face="sans-serif">Hello Hannes,</font>
<br><font size=2 face="sans-serif">check_daemon() now is only used to determine
whether to set/remove queue_if_no_path feature for</font>
<br><font size=2 face="sans-serif">mapped devices, which you said maybe
another issue, we are looking forward for your patch.</font>
<br>
<br><font size=2 face="sans-serif">Thanks,</font>
<br><font size=2 face="sans-serif">Tang</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">发件人:
</font><font size=1 face="sans-serif">Hannes Reinecke
<hare@suse.de></font>
<br><font size=1 color=#5f5f5f face="sans-serif">收件人:
</font><font size=1 face="sans-serif">tang.junhui@zte.com.cn,
bmarzins@redhat.com, </font>
<br><font size=1 color=#5f5f5f face="sans-serif">抄送:
</font><font size=1 face="sans-serif">Bart Van Assche
<bart.vanassche@sandisk.com>, device-mapper development <dm-devel@redhat.com>,
zhang.kai16@zte.com.cn</font>
<br><font size=1 color=#5f5f5f face="sans-serif">日期:
</font><font size=1 face="sans-serif">2016/10/11
18:42</font>
<br><font size=1 color=#5f5f5f face="sans-serif">主题:
</font><font size=1 face="sans-serif">Re: [dm-devel]
[PATCH] libmultipath: fix multipath -q command logic</font>
<br><font size=1 color=#5f5f5f face="sans-serif">发件人:
</font><font size=1 face="sans-serif">dm-devel-bounces@redhat.com</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>On 10/11/2016 11:17 AM, tang.junhui@zte.com.cn wrote:<br>
> Hello Hannes, Ben,<br>
> Could you have a review for this patch, any comment will be highly<br>
> appreciated.<br>
><br>
> Thanks,<br>
> Tang<br>
><br>
><br>
><br>
><br>
> 发件人: Christophe Varoqui <christophe.varoqui@opensvc.com><br>
> 收件人: tang.junhui@zte.com.cn,<br>
> 抄送: Bart Van Assche <bart.vanassche@sandisk.com>,
device-mapper<br>
> development <dm-devel@redhat.com>, zhang.kai16@zte.com.cn<br>
> 日期: 2016/10/11 14:59<br>
> 主题: Re: [dm-devel] [PATCH] libmultipath:
fix multipath -q<br>
> command logic<br>
> 发件人: dm-devel-bounces@redhat.com<br>
> ------------------------------------------------------------------------<br>
><br>
><br>
><br>
> Hannes, Ben,<br>
><br>
> are you ok with the solution to these two issues.<br>
> Seems sane to me.<br>
><br>
This actually is only part of the story.<br>
<br>
The whole idea of issuing 'multipath' is to check if a given path <br>
_should_ be multipathed (as this is typically called from an udev event).<br>
But as it's called from an udev event we cannot rely on the multipath <br>
daemon to be started; we might just handle an event which came in before
<br>
multipathd got started from systemd.<br>
So checking for the PID file is not enough, we need to check if the <br>
daemon will be started eventually.<br>
And in fact checking the PID file or calling mpath_connect() is <br>
equivalent, with the added advantage the mpath_connect() will start the
<br>
daemon _if enabled by systemd_.<br>
So this patch doesn't help much, as it doesn't solve the main problem of
<br>
figuring out if multipathd _should_ be started.<br>
<br>
I've done a patch for checking the '.wants' directories from systemd, <br>
but this obviously will only work if the OS is systemd-based.<br>
And it's not really perfect, as there are corner-cases where just <br>
checking for the .wants directory is not enough.<br>
<br>
Cheers,<br>
<br>
Hannes<br>
-- <br>
Dr. Hannes Reinecke
zSeries & Storage<br>
hare@suse.de
+49 911 74053 688<br>
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg<br>
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)<br>
<br>
--<br>
dm-devel mailing list<br>
dm-devel@redhat.com<br>
</font></tt><a href="https://www.redhat.com/mailman/listinfo/dm-devel"><tt><font size=2>https://www.redhat.com/mailman/listinfo/dm-devel</font></tt></a>
<br>