<font size=2 face="sans-serif"><br>
</font>
<br><font size=2 face="sans-serif">Please have a review for this patch,
hope for your comments.</font>
<br>
<br><font size=2 face="sans-serif">Thanks</font>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">发件人:
</font><font size=1 face="sans-serif">peng.liang5@zte.com.cn</font>
<br><font size=1 color=#5f5f5f face="sans-serif">收件人:
</font><font size=1 face="sans-serif">christophe
varoqui <christophe.varoqui@free.fr>, </font>
<br><font size=1 color=#5f5f5f face="sans-serif">抄送:
</font><font size=1 face="sans-serif">zhang.kai16@zte.com.cn,
dm-devel@redhat.com, peng liang <peng.liang5@zte.com.cn></font>
<br><font size=1 color=#5f5f5f face="sans-serif">日期:
</font><font size=1 face="sans-serif">2016-08-04
15:31</font>
<br><font size=1 color=#5f5f5f face="sans-serif">主题:
</font><font size=1 face="sans-serif">[dm-devel] [PATCH]
multipathd: fix issue in 'map $map getprstatus' reply</font>
<br><font size=1 color=#5f5f5f face="sans-serif">发件人:
</font><font size=1 face="sans-serif">dm-devel-bounces@redhat.com</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>From: peng liang <peng.liang5@zte.com.cn><br>
<br>
-add missing newline to 'map|multipath $map getprstatus' reply<br>
-use asprintf instead of sprintf<br>
<br>
Signed-off-by: peng liang <peng.liang5@zte.com.cn><br>
---<br>
multipathd/cli_handlers.c | 14 ++++++--------<br>
1 file changed, 6 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/multipathd/cli_handlers.c b/multipathd/cli_handlers.c<br>
index 8ff4362..16445ea 100644<br>
--- a/multipathd/cli_handlers.c<br>
+++ b/multipathd/cli_handlers.c<br>
@@ -1,6 +1,9 @@<br>
/*<br>
* Copyright (c) 2005 Christophe Varoqui<br>
*/<br>
+#define _GNU_SOURCE<br>
+<br>
+#include <stdio.h><br>
#include "checkers.h"<br>
#include "memory.h"<br>
#include "vector.h"<br>
@@ -1285,14 +1288,9 @@ cli_getprstatus (void * v, char ** reply, int *
len, void * data)<br>
<br>
condlog(3,
"%s: prflag = %u", param, (unsigned int)mpp->prflag);<br>
<br>
-
*reply =(char *)malloc(2);<br>
-
*len = 2;<br>
-
memset(*reply,0,2);<br>
-<br>
-<br>
-
sprintf(*reply,"%d",mpp->prflag);<br>
-
(*reply)[1]='\0';<br>
-<br>
+
*len = asprintf(reply, "%d\n", mpp->prflag);<br>
+
if (*len < 0)<br>
+
return
1;<br>
<br>
condlog(3,
"%s: reply = %s", param, *reply);<br>
<br>
-- <br>
2.8.1.windows.1<br>
<br>
--<br>
dm-devel mailing list<br>
dm-devel@redhat.com<br>
</font></tt><a href="https://www.redhat.com/mailman/listinfo/dm-devel"><tt><font size=2>https://www.redhat.com/mailman/listinfo/dm-devel</font></tt></a><tt><font size=2><br>
</font></tt>