<div dir="ltr">Hi PengLiang,<div><br></div><div>As no objection was raised, I'll merge this patch.</div><div>Can you resend with the necessary man page update explaining the new policy for max_fds ?</div><div><br></div><div>Thanks.<br><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 27, 2016 at 11:22 AM, <span dir="ltr"><<a href="mailto:peng.liang5@zte.com.cn" target="_blank">peng.liang5@zte.com.cn</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: PengLiang <<a href="mailto:peng.liang5@zte.com.cn">peng.liang5@zte.com.cn</a>><br>
<br>
If user config the max_fds too small to less than actual open files of multipath,<br>
it will occur the error like "/lib/superpath/libchecktur.<wbr>so: cannot open shared<br>
object file: Too many open files".<br>
So set a safe limit to 4096 when user config max_fds less than 4096.<br>
<br>
Signed-off-by: PengLiang <<a href="mailto:peng.liang5@zte.com.cn">peng.liang5@zte.com.cn</a>><br>
---<br>
libmultipath/dict.c | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/libmultipath/dict.c b/libmultipath/dict.c<br>
index 7c21e72..7291e0e 100644<br>
--- a/libmultipath/dict.c<br>
+++ b/libmultipath/dict.c<br>
@@ -733,6 +733,9 @@ max_fds_handler(struct config *conf, vector strvec)<br>
if (conf->max_fds > max_fds)<br>
conf->max_fds = max_fds;<br>
<br>
+ if (conf->max_fds < 4096)<br>
+ conf->max_fds = 4096;<br>
+<br>
FREE(buff);<br>
<br>
return r;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.8.1.windows.1<br>
<br>
</font></span></blockquote></div><br></div>