<div dir="ltr">Applied<div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 11, 2017 at 3:12 PM, Gris Ge <span dir="ltr"><<a href="mailto:fge@redhat.com" target="_blank">fge@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">According to <a href="https://gcc.gnu.org/onlinedocs/gcc/Type-Attributes.html" rel="noreferrer" target="_blank">https://gcc.gnu.org/<wbr>onlinedocs/gcc/Type-<wbr>Attributes.html</a> ,<br>
type attributes should be placed immediately after the struct, union or<br>
enum keyword.<br>
<br>
Signed-off-by: Gris Ge <<a href="mailto:fge@redhat.com">fge@redhat.com</a>><br>
---<br>
libdmmp/libdmmp/libdmmp.h | 8 ++++----<br>
libdmmp/libdmmp_private.h | 3 ++-<br>
2 files changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/libdmmp/libdmmp/libdmmp.h b/libdmmp/libdmmp/libdmmp.h<br>
index 3fc8e6f..0679158 100644<br>
--- a/libdmmp/libdmmp/libdmmp.h<br>
+++ b/libdmmp/libdmmp/libdmmp.h<br>
@@ -73,18 +73,18 @@ extern "C" {<br>
*/<br>
DMMP_DLL_EXPORT const char *dmmp_log_priority_str(int priority);<br>
<br>
-DMMP_DLL_EXPORT struct dmmp_context;<br>
+struct DMMP_DLL_EXPORT dmmp_context;<br>
<br>
-DMMP_DLL_EXPORT struct dmmp_mpath;<br>
+struct DMMP_DLL_EXPORT dmmp_mpath;<br>
<br>
-DMMP_DLL_EXPORT struct dmmp_path_group;<br>
+struct DMMP_DLL_EXPORT dmmp_path_group;<br>
<br>
#define DMMP_PATH_GROUP_STATUS_UNKNOWN 0<br>
#define DMMP_PATH_GROUP_STATUS_ENABLED 1<br>
#define DMMP_PATH_GROUP_STATUS_<wbr>DISABLED 2<br>
#define DMMP_PATH_GROUP_STATUS_ACTIVE 3<br>
<br>
-DMMP_DLL_EXPORT struct dmmp_path;<br>
+struct DMMP_DLL_EXPORT dmmp_path;<br>
<br>
#define DMMP_PATH_STATUS_UNKNOWN 0<br>
//#define DMMP_PATH_STATUS_UNCHECKED 1<br>
diff --git a/libdmmp/libdmmp_private.h b/libdmmp/libdmmp_private.h<br>
index e23c995..3e813cb 100644<br>
--- a/libdmmp/libdmmp_private.h<br>
+++ b/libdmmp/libdmmp_private.h<br>
@@ -47,7 +47,8 @@ extern "C" {<br>
<br>
#define _DMMP_PATH_GROUP_ID_UNKNOWN 0<br>
<br>
-DMMP_DLL_LOCAL struct _num_str_conv {<br>
+struct DMMP_DLL_LOCAL _num_str_conv;<br>
+struct _num_str_conv {<br>
const uint32_t value;<br>
const char *str;<br>
};<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.12.0<br>
<br>
--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com">dm-devel@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/dm-devel</a><br>
</font></span></blockquote></div><br></div>