<div dir="ltr"><div>Hi Martin,</div><div><br></div>Thanks for pointing these missing patches.<div>They are now merged.</div><div><br></div><div>Best,</div><div>Christophe.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 2, 2020 at 10:51 PM Martin Wilck <<a href="mailto:Martin.Wilck@suse.com">Martin.Wilck@suse.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Christophe,<br>
<br>
On Mon, 2020-03-02 at 11:19 +0100, Christophe Varoqui wrote:<br>
> Hi ben, Martin,<br>
> <br>
> I finally catched up with your changes from october till now.<br>
> Please review I did not mess up the merges, then i'll commit a<br>
> version bump.<br>
<br>
This is great, thanks a lot!<br>
I admit that I was starting to get nervous :-)<br>
<br>
It seems that you missed the following patches from me, reviewed by<br>
Ben:<br>
<br>
 * My "Drop nr_active, and some more fixes" series from 11/19<br>
   - "multipathd: move set_no_path_retry() back to libmultipath"<br>
      Review: <a href="https://www.redhat.com/archives/dm-devel/2019-November/msg00099.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2019-November/msg00099.html</a><br>
   - libmultipath: dict.c: rename duplicate set_no_path_retry()<br>
      Review: <a href="https://www.redhat.com/archives/dm-devel/2019-November/msg00100.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2019-November/msg00100.html</a><br>
   - libmultipath: drop mpp->nr_active field<br>
      Review: <a href="https://www.redhat.com/archives/dm-devel/2019-December/msg00037.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2019-December/msg00037.html</a><br>
   - libmultipath: fix (max_)polling_interval setting logic<br>
     Review: <a href="https://www.redhat.com/archives/dm-devel/2019-November/msg00101.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2019-November/msg00101.html</a><br>
   - libmultipath: fix ALUA autodetection when paths are down<br>
     Review: <a href="https://www.redhat.com/archives/dm-devel/2019-November/msg00107.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2019-November/msg00107.html</a><br>
<br>
 * libmultipath: fix compilation with -fno-common<br>
   Review: <a href="https://www.redhat.com/archives/dm-devel/2020-January/msg00118.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2020-January/msg00118.html</a><br>
 * libmultipath: fix files read from config_dir (from Enzo):<br>
   Review (by me): <a href="https://www.redhat.com/archives/dm-devel/2020-February/msg00058.html" rel="noreferrer" target="_blank">https://www.redhat.com/archives/dm-devel/2020-February/msg00058.html</a><br>
<br>
Furthermore, as I indicated before, I'd like to propose a minor change on top of Ben's<br>
last series before you tag a new version. No C code changes, just build logic for<br>
unit tests, and a README. I'll post it ASAP.<br>
<br>
Regards<br>
Martin<br>
<br>
-- <br>
Dr. Martin Wilck <<a href="mailto:mwilck@suse.com" target="_blank">mwilck@suse.com</a>>, Tel. +49 (0)911 74053 2107<br>
SUSE<br>
Software Solutions Germany GmbH <br>
HRB 36809 (AG Nürnberg) GF: Felix<br>
Imendörffer<br>
<br>
</blockquote></div>