<div dir="ltr"><div dir="ltr">On Sun, Jun 6, 2021 at 10:14 PM Mikulas Patocka <<a href="mailto:mpatocka@redhat.com">mpatocka@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">When comitting superblock, we need to write just one block, we don't need<br>
to write full page. Some architectures have pages larger than 4k and<br>
committing full page is needless overhead.<br>
<br>
Signed-off-by: Mikulas Patocka <<a href="mailto:mpatocka@redhat.com" target="_blank">mpatocka@redhat.com</a>><br>
<br>
Index: linux-2.6/drivers/md/dm-writecache.c<br>
===================================================================<br>
--- linux-2.6.orig/drivers/md/dm-writecache.c<br>
+++ linux-2.6/drivers/md/dm-writecache.c<br>
@@ -532,11 +532,7 @@ static void ssd_commit_superblock(struct<br>
<br>
        region.bdev = wc->ssd_dev->bdev;<br>
        region.sector = 0;<br>
-       region.count = PAGE_SIZE >> SECTOR_SHIFT;<br>
-<br>
-       if (unlikely(region.sector + region.count > wc->metadata_sectors))<br>
-               region.count = wc->metadata_sectors - region.sector;<br>
-<br>
+       region.count = wc->block_size >> SECTOR_SHIFT;<br></blockquote><div><br></div><div>You can use to_sector() here.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
        region.sector += wc->start_sector;<br>
<br>
        req.bi_op = REQ_OP_WRITE;<br>
<br>
--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com" target="_blank">dm-devel@redhat.com</a><br>
<a href="https://listman.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer" target="_blank">https://listman.redhat.com/mailman/listinfo/dm-devel</a><br>
<br>
</blockquote></div></div>