<div dir="ltr"><div dir="ltr">On Thu, Mar 30, 2023 at 11:28 PM Tom Rix <<a href="mailto:trix@redhat.com" target="_blank">trix@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">clang with W=1 reports<br>
drivers/md/dm-raid.c:2212:15: error: variable<br>
'd' set but not used [-Werror,-Wunused-but-set-variable]<br>
unsigned int d;<br>
^<br>
This variable is not used so remove it.<br>
<br>
Signed-off-by: Tom Rix <<a href="mailto:trix@redhat.com" target="_blank">trix@redhat.com</a>><br>
---<br>
drivers/md/dm-raid.c | 4 ----<br>
1 file changed, 4 deletions(-)<br>
<br>
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c<br>
index 60632b409b80..2dfd51509647 100644<br>
--- a/drivers/md/dm-raid.c<br>
+++ b/drivers/md/dm-raid.c<br>
@@ -2209,7 +2209,6 @@ static int super_load(struct md_rdev *rdev, struct md_rdev *refdev)<br>
static int super_init_validation(struct raid_set *rs, struct md_rdev *rdev)<br>
{<br>
int role;<br>
- unsigned int d;<br>
struct mddev *mddev = &rs->md;<br>
uint64_t events_sb;<br>
uint64_t failed_devices[DISKS_ARRAY_ELEMS];<br>
@@ -2324,7 +2323,6 @@ static int super_init_validation(struct raid_set *rs, struct md_rdev *rdev)<br>
* to provide capacity for redundancy or during reshape<br>
* to add capacity to grow the raid set.<br>
*/<br>
- d = 0;<br>
rdev_for_each(r, mddev) {<br>
if (test_bit(Journal, &rdev->flags))<br>
continue;<br>
@@ -2340,8 +2338,6 @@ static int super_init_validation(struct raid_set *rs, struct md_rdev *rdev)<br>
if (test_bit(FirstUse, &r->flags))<br>
rebuild_and_new++;<br>
}<br>
-<br>
- d++;<br>
}<br>
<br>
if (new_devs == rs->raid_disks || !rebuilds) {<br>
-- <br>
2.27.0<br>
<br>
--<br>
dm-devel mailing list<br>
<a href="mailto:dm-devel@redhat.com" target="_blank">dm-devel@redhat.com</a><br>
<a href="https://listman.redhat.com/mailman/listinfo/dm-devel" rel="noreferrer" target="_blank">https://listman.redhat.com/mailman/listinfo/dm-devel</a><br>
<br></blockquote><div><br></div><div>Acked </div></div></div>