[edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

[Liming Gao]

Push at 39744883933eea9674ccaf243cbf565966b8fa74

From: Fan, ZhijuX
Sent: Friday, June 28, 2019 3:49 PM
To: devel at edk2.groups.io; rebecca at bluestop.org
Cc: Gao, Liming <liming.gao at intel.com>; Feng, Bob C <bob.c.feng at intel.com>
Subject: RE: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

Hi:

You're right, but at least we won't have to worry about this until “python3.10”

·         And we're comparing directory names, "Python 3.6.6" doesn't appear in the Python version we found

·         We find python applications using “whereis python”   “/usr/bin/python3.6” “/usr/local/bin/python3.6”

·         Later we can compare the form of string length to add a layer of judgment, but we don't need it now.


Any question, please let me know. Thanks.

Best Regards
Fan Zhiju



From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> [mailto:devel at edk2.groups.io] On Behalf Of rebecca at bluestop.org<mailto:rebecca at bluestop.org>
Sent: Wednesday, June 26, 2019 11:48 PM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Fan, ZhijuX <zhijux.fan at intel.com<mailto:zhijux.fan at intel.com>>
Cc: Gao, Liming <liming.gao at intel.com<mailto:liming.gao at intel.com>>; Feng, Bob C <bob.c.feng at intel.com<mailto:bob.c.feng at intel.com>>
Subject: Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

On 2019-06-25 22:46, Fan, ZhijuX wrote:

Hi:
Python3.6 and python3.7
After the code removes some common values “python”, we compare “3.6” and “3.7”
origin_version = “3.6”, python_version=”3.7”

I'm going to change it to
if [[ "$origin_version" < "$python_version" ]]; then





That's fine for now, hopefully it'll keep working as long as it needs to.

But once you're comparing for example 3.7 and 3.12:

[bcran at photon ~]$ if [[ "3.7" > "3.12" ]]; then echo "wrong!"; else echo "correct!"; fi
wrong!

--
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43079): https://edk2.groups.io/g/devel/message/43079
Mute This Topic: https://groups.io/mt/32154778/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20190701/a75225cc/attachment.htm>