[edk2-devel] [PATCH] EmbeddedPkg: Fix various typos
Leif Lindholm
leif.lindholm at linaro.org
Wed Jul 3 15:30:49 UTC 2019
Hi Cœur,
Thank you for your contribution.
Normally, we expect patches to be submitted via git send-email, as
opposed to through the groups.io web interface (it introduces
spectacular levels of corruption to the original patch).
However, as this is a first submission, and it actually worked
surprisingly well to copy/paste the rendered HTML from the gmail web
client, I'm happy to take the patches in their current format.
I notice you experimented with different methods of submitting the
patches. For reference, out of the three patches submitted to packages
I look after (ArmPkg, ArmPlatformPkg and EmbeddedPkg), the ArmPkg one
(attached to email) was the most straightforwards one, and the
EmbeddedPkg one (lacking from/subject headers in the message body) was
the least straightforward one.
Anyway, these 3 patches look good to me:
The change to ArmPkg/Drivers/CpuDxe/Arm/Mmu.c does not look like a
typo fix, but it's non-functional so I'm OK to leave it in.
For ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c, I would probably
have changed to "input" instead of "inputted", but both are valid, and
yours is the strict typo fix of the previous wording.
However, I do need clarification on one point:
You have submitted these patches containing the Contributed-under:
tag. We have recently(ish) dropped the TianoCore Contribution
Agreement in favour of relicensing the code under the BSD+Patent
license [1].
Use of the Contributed-under tag indicates you may have missed this
change, so could you confirm whether you are happy to contribute these
patches under BSD+Patent?
Best Regards,
Leif
[1] https://spdx.org/licenses/BSD-2-Clause-Patent.html
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43222): https://edk2.groups.io/g/devel/message/43222
Mute This Topic: https://groups.io/mt/32238806/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list