[edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

[Bob Feng]

OK. Thanks. 

I just noticed my local repo is still in devel-minplatform branch.

Thanks,
Bob

-----Original Message-----
From: Bi, Dandan 
Sent: Thursday, July 4, 2019 8:55 AM
To: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

Hi Bob,

I have updated GitEdk2MinMtOlympus.bat for minpurely via https://github.com/tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417
And GitEdk2MinKabylake.bat for minkabylake has been removed  via https://github.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2fa66cc97af30c835c

Both of the platforms should build ok now. 



Thanks,
Dandan

> -----Original Message-----
> From: Feng, Bob C
> Sent: Wednesday, July 3, 2019 8:23 PM
> To: Gao, Liming <liming.gao at intel.com>; Bi, Dandan 
> <dandan.bi at intel.com>; devel at edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> 
> Hi Dandan,
> 
> I found the GitEdk2MinMtOlympus.bat for minpurely and 
> GitEdk2MinKabylake.bat for minkabylake need to update. Would you 
> update it?
> 
> Thanks,
> Bob
> 
> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, June 28, 2019 9:12 AM
> To: Bi, Dandan <dandan.bi at intel.com>; Feng, Bob C 
> <bob.c.feng at intel.com>; devel at edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> 
> Dandan:
> 
>  If you find any pre script to use --nt32 option, please remove them 
> first, then do this change.
> 
> >-----Original Message-----
> >From: Bi, Dandan
> >Sent: Friday, June 28, 2019 9:11 AM
> >To: Gao, Liming <liming.gao at intel.com>; Feng, Bob C 
> ><bob.c.feng at intel.com>; devel at edk2.groups.io
> >Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >
> >Hi Liming and Bob,
> >
> >Thanks for the review. So we reach the agreement that remove the 
> >--nt32 flag, right? If so, I will address Liming's comments and then 
> >push these two patches.
> >
> >
> >Thanks,
> >Dandan
> >
> >> -----Original Message-----
> >> From: Gao, Liming
> >> Sent: Thursday, June 27, 2019 11:17 PM
> >> To: Feng, Bob C <bob.c.feng at intel.com>; Bi, Dandan 
> >> <dandan.bi at intel.com>; devel at edk2.groups.io
> >> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >>
> >> Yes. Those script needs to be updated together.
> >>
> >> > -----Original Message-----
> >> > From: Feng, Bob C
> >> > Sent: Thursday, June 27, 2019 11:14 PM
> >> > To: Gao, Liming <liming.gao at intel.com>; Bi, Dandan 
> >> > <dandan.bi at intel.com>; devel at edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > OK.  I think it may break some pre-build script if the pre-build 
> >> > script have
> >> "edksetup --nt32"...
> >> >
> >> > -----Original Message-----
> >> > From: Gao, Liming
> >> > Sent: Thursday, June 27, 2019 10:48 PM
> >> > To: Feng, Bob C <bob.c.feng at intel.com>; Bi, Dandan 
> >> > <dandan.bi at intel.com>; devel at edk2.groups.io
> >> > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> >
> >> > Bob:
> >> >   --nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been 
> >> > removed. So,
> >> I think it is fine to remove --nt32 option.
> >> >
> >> > > -----Original Message-----
> >> > > From: Feng, Bob C
> >> > > Sent: Thursday, June 27, 2019 7:56 PM
> >> > > To: Bi, Dandan <dandan.bi at intel.com>; devel at edk2.groups.io
> >> > > Cc: Gao, Liming <liming.gao at intel.com>
> >> > > Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch 
> >> > > files
> >> > >
> >> > > The patches look good.
> >> > >
> >> > > I think removing --nt32 option is incompatible change. What 
> >> > > about keep
> >> the --nt32 ?
> >> > >
> >> > > For the Patch 2 setup for different VS tool chains.
> >> > > Reviewed-by: Bob Feng <bob.c.feng at intel.com>
> >> > >
> >> > > Thanks,
> >> > > Bob
> >> > >
> >> > > -----Original Message-----
> >> > > From: Bi, Dandan
> >> > > Sent: Sunday, June 23, 2019 9:59 PM
> >> > > To: devel at edk2.groups.io
> >> > > Cc: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming 
> >> > > <liming.gao at intel.com>
> >> > > Subject: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
> >> > >
> >> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
> >> > >
> >> > > Patch 1 remove nt32 related flags in bat files.
> >> > > Patch 2 setup for different VS tool chains.
> >> > >
> >> > > Cc: Bob Feng <bob.c.feng at intel.com>
> >> > > Cc: Liming Gao <liming.gao at intel.com> Dandan Bi (2):
> >> > >   Edk2: Remove nt32 related flag in bat files
> >> > >   Edk2Setup: Support different VS tool chain setup
> >> > >
> >> > >  BaseTools/get_vsvars.bat        | 42 +++++++++++++++++++++----
> >> > >  BaseTools/set_vsprefix_envs.bat | 47
> +++++++++++++++++++++++++-
> >-
> >> -
> >> > >  BaseTools/toolsetup.bat         | 68
> >> ++++++++++++++++++++++++++++++++++-------
> >> > >  edksetup.bat                    | 32 ++++++-------------
> >> > >  4 files changed, 145 insertions(+), 44 deletions(-)
> >> > >
> >> > > --
> >> > > 1.9.5.msysgit.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43242): https://edk2.groups.io/g/devel/message/43242
Mute This Topic: https://groups.io/mt/32177263/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-