[edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64

Leif Lindholm leif.lindholm at linaro.org
Thu Jul 4 14:27:11 UTC 2019


On Thu, Jul 04, 2019 at 06:14:04AM +0000, Wu, Hao A wrote:
> I do met a little problem that for a patch that touches multiple features,
> the contacts order in the output is not ideally perfect:
> 
> Content in Maintainers.txt:
> '''
> MdeModulePkg
> F: MdeModulePkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
> M: Jian J Wang <jian.j.wang at intel.com>
> M: Hao A Wu <hao.a.wu at intel.com>
> 
> F: MdeModulePkg/*Ufs*/
> R: Ufs Guy <ufs at test.com>
> 
> F: MdeModulePkg/Include/*Hii*.h
> F: MdeModulePkg/*Hii*/
> R: Hii Guy <hii at test.com>
> '''
> 
> Script output:
> '''
> $ py BaseTools/Scripts/GetMaintainer.py HEAD
> MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf
> MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.uni
>   Jian J Wang <jian.j.wang at intel.com>
>   Hao A Wu <hao.a.wu at intel.com>
>   Ufs Guy <ufs at test.com>
>   devel at edk2.groups.io
>   Hii Guy <hii at test.com>
> '''
> 
> The 'Hii Guy' is at the end of the list.

Totally agree. The idea was to keep the first revision simple.
Another thing missing (that I would argue is even more important than
listed order), is an indication of *why* said person is listed.

> But this is a rather minor problem and does not impact the use at all.

Good. I will respin the set based on Laszlo's feedback on previous
version and resubmit.

Best Regards,

Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43277): https://edk2.groups.io/g/devel/message/43277
Mute This Topic: https://groups.io/mt/32067941/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list