[edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

Laszlo Ersek lersek at redhat.com
Tue Jul 16 01:37:19 UTC 2019


On 07/16/19 00:25, Rebecca Cran wrote:
> Signed-off-by: Rebecca Cran <rebecca at bsdio.com>
> ---
>  edksetup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/edksetup.sh b/edksetup.sh
> index 12a3e26a67..ab58fe4a6e 100755
> --- a/edksetup.sh
> +++ b/edksetup.sh
> @@ -71,7 +71,7 @@ function SetWorkspace()
>    #
>    # Set $WORKSPACE
>    #
> -  export WORKSPACE=`pwd`
> +  export WORKSPACE=$PWD
>    return 0
>  }
>  
> 

(Sorry if the reason was already given and I missed it:)

Why is this an improvement?

The docs at <https://man.openbsd.org/pwd.1> say:

"pwd also exists as a built-in to ksh(1), which may have a different
default behavior". Is that the reason?

Thanks!
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43756): https://edk2.groups.io/g/devel/message/43756
Mute This Topic: https://groups.io/mt/32483820/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list