[edk2-devel] [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements

[Laszlo Ersek]

On 07/16/19 03:47, Laszlo Ersek wrote:
> On 07/16/19 00:25, Rebecca Cran wrote:
>> Signed-off-by: Rebecca Cran <rebecca at bsdio.com>
>> ---
>>  edksetup.sh | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/edksetup.sh b/edksetup.sh
>> index e2f116f8bc..ba055d5d5a 100755
>> --- a/edksetup.sh
>> +++ b/edksetup.sh
>> @@ -118,7 +118,7 @@ function SetupPython3()
>>  
>>  function SetupPython()
>>  {
>> -  if [ $PYTHON_COMMAND ] && [ -z $PYTHON3_ENABLE ];then
>> +  if [ -n "$PYTHON_COMMAND" ] && [ -z "$PYTHON3_ENABLE" ];then
>>      if ( command -v $PYTHON_COMMAND >/dev/null 2>&1 );then
>>        return 0
>>      else
>> @@ -127,7 +127,7 @@ function SetupPython()
>>      fi
>>    fi
>>  
>> -  if [ $PYTHON3_ENABLE ] && [ $PYTHON3_ENABLE == TRUE ]
>> +  if [ "$PYTHON3_ENABLE" == "TRUE" ]
>>    then
>>      SetupPython3
>>    fi
>>
> 
> This patch looks sane, but I don't understand why it stops here. There
> are more variable references that could be quoted; for example, just
> after the above, we have:
> 
>   if [ $PYTHON3_ENABLE ] && [ $PYTHON3_ENABLE != TRUE ]

Ah wait, that code is removed in patch #5.

But, I think the question stands; there's more that could be quoted.
What is the reason for quoting just these?

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43761): https://edk2.groups.io/g/devel/message/43761
Mute This Topic: https://groups.io/mt/32483828/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-