[edk2-devel] [PATCH 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command

[Laszlo Ersek]

On 07/16/19 04:13, Rebecca Cran wrote:
> On 2019-07-15 19:37, Laszlo Ersek wrote:
>>
>> (Sorry if the reason was already given and I missed it:)
>>
>> Why is this an improvement?
>>
>> The docs at <https://man.openbsd.org/pwd.1> say:
>>
>> "pwd also exists as a built-in to ksh(1), which may have a different
>> default behavior". Is that the reason?
> 
> No, it's mainly as a (very minor) optimization: `pwd` runs the command
> (even as a built-in), whereas $PWD simply evaluates the value of the
> variable.
> 
> Also, modern scripts as I understand it should generally use $(...) to
> run commands, instead of `...`.
> 
> 

Makes sense, thanks.

For this patch:

Reviewed-by: Laszlo Ersek <lersek at redhat.com>

Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43779): https://edk2.groups.io/g/devel/message/43779
Mute This Topic: https://groups.io/mt/32483820/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-