[edk2-devel] [PATCH 5/6] edksetup.sh: Simplify SetupPython3 and SetupPython functions.
Laszlo Ersek
lersek at redhat.com
Tue Jul 16 10:38:00 UTC 2019
On 07/16/19 04:27, Rebecca Cran wrote:
> On 2019-07-15 20:16, Laszlo Ersek wrote:
>> That said, if you wouldn't like to rework the patch, I can give my R-b
>> as-is (please confirm).
>
>
> Thanks, I like your suggested changes. And I just ran shellcheck and was
> told "SC2230: which is non-standard. Use builtin 'command -v' instead.".
Great, and thank you for teaching me about "shellcheck". (I generally
use the POSIX spec, and "dash", when I try to write portable shell scripts.)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43782): https://edk2.groups.io/g/devel/message/43782
Mute This Topic: https://groups.io/mt/32483827/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list