[edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

Leif Lindholm leif.lindholm at linaro.org
Tue Jul 16 13:53:13 UTC 2019 

Hi Hao Wu,

Are you ready to send out a v1 yet? (Or did I miss it?)
I would prefer to get this in before the GetMaintainer.py script, and
after the comment updates to Maintainers.txt.

Best Regards,

Leif

On Mon, Jun 24, 2019 at 01:16:05AM +0000, Wu, Hao A wrote:
> Hello all,
> 
> With Leif's comment on the better usage of the wildcard character & 'X:' tag:
> https://edk2.groups.io/g/devel/message/42587
> 
> The list is updated as shown below.
> 
> Also, I forgot to mention that some directory/file may be classified into
> multiple classes. I think it is a valid case, for example:
> 
> MdeModulePkg/Library/SmmMemoryAllocationProfileLib
> 
> matches both 'Memory Management' and 'SMM' sections:
> 
> Memory Management - F: MdeModulePkg/*Mem*/
> SMM               - F: MdeModulePkg/*Smm*/
> 
> Then, reviewers from both classes should be Cc-ed when changes are made in
> the above library.
> 
> If the updated list is good enough, the next step will be determining the
> reviewer(s) for each feature in the list.
> 
> 
> The updated list:
> ACPI:
> F: MdeModulePkg/Include/*/*Acpi*.h
> F: MdeModulePkg/Universal/Acpi/
> 
> BDS:
> F: MdeModulePkg/*BootManager*/
> X: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/Library/UefiBootManagerLib.h
> F: MdeModulePkg/Universal/BdsDxe/
> F: MdeModulePkg/Universal/LoadFileOnFv2/
> F: MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.*
> 
> Console:
> F: MdeModulePkg/Include/Guid/ConnectConInEvent.h
> F: MdeModulePkg/Include/Guid/Console*.h
> F: MdeModulePkg/Include/Guid/StandardErrorDevice.h
> F: MdeModulePkg/Include/Guid/TtyTerm.h
> F: MdeModulePkg/Universal/Console/
> X: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> 
> Core (PEI, DXE and Runtime):
> F: MdeModulePkg/*SectionExtract*/
> F: MdeModulePkg/Core/Dxe/
> X: MdeModulePkg/Core/Dxe/Gcd/
> X: MdeModulePkg/Core/Dxe/Mem/
> F: MdeModulePkg/Core/DxeIplPeim/
> F: MdeModulePkg/Core/Pei/
> X: MdeModulePkg/Core/Pei/Memory/
> X: MdeModulePkg/Core/Pei/PciCfg2/
> X: MdeModulePkg/Core/Pei/Reset/
> X: MdeModulePkg/Core/Pei/StatusCode/
> F: MdeModulePkg/Core/RuntimeDxe/
> F: MdeModulePkg/Include/Guid/Crc32GuidedSectionExtraction.h
> F: MdeModulePkg/Include/Guid/EventExitBootServiceFailed.h
> F: MdeModulePkg/Include/Guid/IdleLoopEvent.h
> F: MdeModulePkg/Include/Guid/LoadModuleAtFixedAddress.h
> F: MdeModulePkg/Include/Library/SecurityManagementLib.h
> F: MdeModulePkg/Library/DxeSecurityManagementLib/
> F: MdeModulePkg/Universal/PlatformDriOverrideDxe/
> F: MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c
> 
> Debug:
> F: MdeModulePkg/*Debug*/
> X: MdeModulePkg/Universal/EbcDxe/EbcDebugger/
> F: MdeModulePkg/Include/Guid/DebugMask.h
> F: MdeModulePkg/Include/Library/DebugAgentLib.h
> F: MdeModulePkg/Include/Ppi/Debug.h
> 
> Decompress:
> F: MdeModulePkg/Include/Guid/LzmaDecompress.h
> F: MdeModulePkg/Library/*Decompress*/
> 
> Device:
> F: MdeModulePkg/*Serial*/
> X: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Bus/
> X: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> X: MdeModulePkg/Bus/Pci/PciBusDxe/
> X: MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
> F: MdeModulePkg/Include/*/*Ata*.h
> F: MdeModulePkg/Include/*/*NonDiscoverableDevice*.h
> F: MdeModulePkg/Include/*/*NvmExpress*.h
> F: MdeModulePkg/Include/*/*SerialPort*.h
> F: MdeModulePkg/Include/*/*SdMmc*.h
> F: MdeModulePkg/Include/*/*Ufs*.h
> F: MdeModulePkg/Include/*/*Usb*.h
> F: MdeModulePkg/Include/Guid/S3StorageDeviceInitList.h
> F: MdeModulePkg/Include/Guid/RecoveryDevice.h
> F: MdeModulePkg/Include/Ppi/StorageSecurityCommand.h
> F: MdeModulePkg/Include/Protocol/Ps2Policy.h
> F: MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/
> 
> Disk:
> F: MdeModulePkg/Universal/Disk/
> 
> EBC:
> F: MdeModulePkg/Include/*/*Ebc*.h
> F: MdeModulePkg/Include/Protocol/DebuggerConfiguration.h
> F: MdeModulePkg/Universal/EbcDxe/
> 
> Firmware Update:
> F: MdeModulePkg/*Capsule*/
> F: MdeModulePkg/Include/*/*Capsule*.h
> F: MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
> F: MdeModulePkg/Include/Library/FmpAuthenticationLib.h
> F: MdeModulePkg/Include/Protocol/EsrtManagement.h
> F: MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
> F: MdeModulePkg/Library/DisplayUpdateProgressLib*/
> F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> F: MdeModulePkg/Universal/Esrt*/
> 
> Graphic:
> F: MdeModulePkg/*Logo*/
> F: MdeModulePkg/Include/*/*Logo*.h
> F: MdeModulePkg/Include/Library/BmpSupportLib.h
> F: MdeModulePkg/Include/Library/FrameBufferBltLib.h
> F: MdeModulePkg/Library/BaseBmpSupportLib/
> F: MdeModulePkg/Library/FrameBufferBltLib/
> F: MdeModulePkg/Universal/Console/GraphicsOutputDxe/
> 
> HII/UI:
> F: MdeModulePkg/*FileExplorer*/
> F: MdeModulePkg/*Hii*/
> F: MdeModulePkg/*Ui*/
> F: MdeModulePkg/Application/BootManagerMenuApp/
> F: MdeModulePkg/Include/*/*FileExplorer*.h
> F: MdeModulePkg/Include/*/*FormBrowser*.h
> F: MdeModulePkg/Include/*/*Hii*.h
> F: MdeModulePkg/Include/Library/CustomizedDisplayLib.h
> F: MdeModulePkg/Include/Protocol/DisplayProtocol.h
> F: MdeModulePkg/Library/CustomizedDisplayLib/
> F: MdeModulePkg/Universal/DisplayEngineDxe/
> F: MdeModulePkg/Universal/SetupBrowserDxe/
> 
> IPMI:
> F: MdeModulePkg/Include/*/*Ipmi*.h
> F: MdeModulePkg/Library/*Ipmi*/
> 
> Memory Management:
> F: MdeModulePkg/*Mem*/
> F: MdeModulePkg/Core/Dxe/Gcd/
> F: MdeModulePkg/Include/*/*Mem*.h
> F: MdeModulePkg/Include/*/*IoMmu*.h
> 
> PCD:
> F: MdeModulePkg/Application/DumpDynPcd/
> F: MdeModulePkg/Include/*/*Pcd*.h
> F: MdeModulePkg/Universal/PCD/
> 
> PCI Bus:
> F: MdeModulePkg/*PciHostBridge*/
> F: MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/
> F: MdeModulePkg/Bus/Pci/PciBusDxe/
> F: MdeModulePkg/Core/Pei/PciCfg2/
> F: MdeModulePkg/Include/Library/PciHostBridgeLib.h
> F: MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/
> 
> Performance:
> F: MdeModulePkg/Include/*/*Perf*.h
> F: MdeModulePkg/Library/*Perf*/
> 
> Reset:
> F: MdeModulePkg/*Reset*/
> F: MdeModulePkg/Include/*/*Reset*.h
> 
> S3:
> F: MdeModulePkg/*LockBox*/
> F: MdeModulePkg/Include/*/*BootScript*.h
> F: MdeModulePkg/Include/*/*LockBox*.h
> F: MdeModulePkg/Include/*/*S3*.h
> F: MdeModulePkg/Library/*S3*/
> 
> SMBIOS:
> F: MdeModulePkg/Universal/Smbios*/
> 
> SMM:
> F: MdeModulePkg/*Smi*/
> F: MdeModulePkg/*Smm*/
> F: MdeModulePkg/Include/*/*Smi*.h
> F: MdeModulePkg/Include/*/*Smm*.h
> 
> Status Code:
> F: MdeModulePkg/*StatusCode*/
> F: MdeModulePkg/Include/*/*StatusCode*.h
> 
> Variable:
> F: MdeModulePkg/*Var*/
> F: MdeModulePkg/Include/*/*FaultTolerantWrite*.h
> F: MdeModulePkg/Include/*/*Var*.h
> F: MdeModulePkg/Include/Guid/SystemNvDataGuid.h
> F: MdeModulePkg/Include/Protocol/SwapAddressRange.h
> F: MdeModulePkg/Universal/FaultTolerantWrite*/
> 
> Misc:
> F: MdeModulePkg/Application/HelloWorld/
> F: MdeModulePkg/Include/Guid/F: MdeModulePkgTokenSpace.h
> F: MdeModulePkg/Include/Guid/MtcVendor.h
> F: MdeModulePkg/Include/Guid/ZeroGuid.h
> F: MdeModulePkg/Include/Library/CpuExceptionHandlerLib.h
> F: MdeModulePkg/Include/Library/PlatformHookLib.h
> F: MdeModulePkg/Include/Library/RecoveryLib.h
> F: MdeModulePkg/Include/Library/SortLib.h
> F: MdeModulePkg/Include/Library/TpmMeasurementLib.h
> F: MdeModulePkg/Include/Protocol/Dpc.h
> F: MdeModulePkg/Include/Protocol/LoadPe32Image.h
> F: MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
> F: MdeModulePkg/Include/Protocol/Print2.h
> F: MdeModulePkg/Library/BaseHobLibNull/
> F: MdeModulePkg/Library/BasePlatformHookLibNull/
> F: MdeModulePkg/Library/BaseSortLib/
> F: MdeModulePkg/Library/CpuExceptionHandlerLibNull/
> F: MdeModulePkg/Library/DxePrintLibPrint2Protocol/
> F: MdeModulePkg/Library/PeiRecoveryLibNull/
> F: MdeModulePkg/Library/PlatformHookLibSerialPortPpi/
> F: MdeModulePkg/Library/TpmMeasurementLibNull/
> F: MdeModulePkg/Library/UefiSortLib/
> F: MdeModulePkg/Universal/DevicePathDxe/
> F: MdeModulePkg/Universal/DriverHealthManagerDxe/
> F: MdeModulePkg/Universal/DriverSampleDxe/
> F: MdeModulePkg/Universal/FvSimpleFileSystemDxe/
> F: MdeModulePkg/Universal/LegacyRegion2Dxe/
> F: MdeModulePkg/Universal/Metronome/
> F: MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/
> F: MdeModulePkg/Universal/PrintDxe/
> F: MdeModulePkg/Universal/RegularExpressionDxe/
> F: MdeModulePkg/Universal/TimestampDxe/
> F: MdeModulePkg/Universal/WatchdogTimerDxe/
> 
> 
> Best Regards,
> Hao Wu

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43788): https://edk2.groups.io/g/devel/message/43788
Mute This Topic: https://groups.io/mt/32001926/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

More information about the edk2-devel-archive mailing list