[edk2-devel] [PATCH v4 1/6] edksetup.sh: Use bash variable $PWD instead of executing pwd command
rebecca at bsdio.com
rebecca at bsdio.com
Tue Jul 16 16:55:33 UTC 2019
This is a (very minor) optimization: `pwd` runs the command (even as a
built-in), whereas $PWD simply evaluates the value of the variable.
ALso, modern scripts should generally use $(...) to run commands,
instead of `...`.
Signed-off-by: Rebecca Cran <rebecca at bsdio.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>
---
edksetup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edksetup.sh b/edksetup.sh
index 12a3e26a67..ab58fe4a6e 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -71,7 +71,7 @@ function SetWorkspace()
#
# Set $WORKSPACE
#
- export WORKSPACE=`pwd`
+ export WORKSPACE=$PWD
return 0
}
--
2.22.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43802): https://edk2.groups.io/g/devel/message/43802
Mute This Topic: https://groups.io/mt/32493796/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list