[edk2-devel] [PATCH v4 6/6] edksetup.sh: Add quotes and explicit checks in test statements

[rebecca at bsdio.com]

There are unquoted variables that remain: only the ones considered most
important to fix (in terms of potential bugs) were changed in this
commit.

Signed-off-by: Rebecca Cran <rebecca at bsdio.com>
Reviewed-by: Laszlo Ersek <lersek at redhat.com>
Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>
---
 edksetup.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/edksetup.sh b/edksetup.sh
index 5b90e55ed8..9dc6913ad2 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -118,7 +118,7 @@ function SetupPython3()
 
 function SetupPython()
 {
-  if [ $PYTHON_COMMAND ] && [ -z $PYTHON3_ENABLE ];then
+  if [ -n "$PYTHON_COMMAND" ] && [ -z "$PYTHON3_ENABLE" ];then
     if ( command -v $PYTHON_COMMAND >/dev/null 2>&1 );then
       return 0
     else
@@ -127,7 +127,7 @@ function SetupPython()
     fi
   fi
 
-  if [ $PYTHON3_ENABLE ] && [ $PYTHON3_ENABLE == TRUE ]
+  if [ "$PYTHON3_ENABLE" == "TRUE" ]
   then
     SetupPython3
   fi
-- 
2.22.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43807): https://edk2.groups.io/g/devel/message/43807
Mute This Topic: https://groups.io/mt/32493801/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-