[edk2-devel] [Patch 5/5] UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors simultaneously.

[Ni, Ray]

1. does this module still consume MpPpi? If no, please update the INF.
2. This reminds me that there is another lib instance MpInitLibUp, you need to update that as well.
For *StartupAllCPUs(), implementation in that Up instance can just call the procedure. This abstracts
the behavior so your C code change in this patch can work even MpInitLibUp links to CpuMpPei.

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Dong,
> Eric
> Sent: Friday, July 19, 2019 3:28 PM
> To: devel at edk2.groups.io
> Cc: Ni, Ray <ray.ni at intel.com>; Laszlo Ersek <lersek at redhat.com>; Kumar,
> Chandana C <chandana.c.kumar at intel.com>; Zeng, Star
> <star.zeng at intel.com>
> Subject: [edk2-devel] [Patch 5/5] UefiCpuPkg/RegisterCpuFeaturesLib: Start
> all processors simultaneously.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
> 
> For semaphore type register, it required all processors to do the task at the
> same time.
> Current logic begins BSP's task after all APs have finished their tasks.
> This will caused set semaphore task hang if semaphore has package level
> type.
> This patch use new EDKII_PEI_MP_SERVICES2_PPI to start all processors at
> the same time to fix the potential hang issue.
> 
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Cc: Chandana Kumar <chandana.c.kumar at intel.com>
> Cc: Star Zeng <star.zeng at intel.com>
> Signed-off-by: Eric Dong <eric.dong at intel.com>
> ---
>  .../PeiRegisterCpuFeaturesLib.c               | 62 ++++++++++++++-----
>  .../PeiRegisterCpuFeaturesLib.inf             |  1 +
>  2 files changed, 47 insertions(+), 16 deletions(-)
> 
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> index 8ad5a40e5a..9ed0fbf381 100644
> ---
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
> +++
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLi
> +++ b.c
> @@ -12,6 +12,8 @@
>  #include <Library/PeiServicesLib.h>
>  #include <Library/PeiServicesTablePointerLib.h>
>  #include <Ppi/MpServices.h>
> +#include <Ppi/EdkiiMpServices2.h>
> +
>  #include "RegisterCpuFeatures.h"
> 
>  #define REGISTER_CPU_FEATURES_GUID \
> @@ -180,6 +182,48 @@ StartupAPsWorker (
>    ASSERT_EFI_ERROR (Status);
>  }
> 
> +/**
> +  Worker function to execute a caller provided function on all enabled APs.
> +
> +  @param[in]  Procedure               A pointer to the function to be run on
> +                                      enabled APs of the system.
> +  @param[in]  MpEvent                 The Event used to sync the result.
> +
> +**/
> +VOID
> +StartupCPUsWorker (
> +  IN  EFI_AP_PROCEDURE                 Procedure
> +  )
> +{
> +  EFI_STATUS                           Status;
> +  EDKII_PEI_MP_SERVICES2_PPI           *CpuMp2Ppi;
> +  CPU_FEATURES_DATA                    *CpuFeaturesData;
> +
> +  CpuFeaturesData = GetCpuFeaturesData ();
> +
> +  //
> +  // Get MP Services2 Ppi
> +  //
> +  Status = PeiServicesLocatePpi (
> +             &gEdkiiPeiMpServices2PpiGuid,
> +             0,
> +             NULL,
> +             (VOID **)&CpuMp2Ppi
> +             );
> +  ASSERT_EFI_ERROR (Status);
> +
> +  //
> +  // Wakeup all APs for data collection.
> +  //
> +  Status = CpuMp2Ppi->StartupAllCPUs (
> +                 CpuMp2Ppi,
> +                 Procedure,
> +                 0,
> +                 CpuFeaturesData
> +                 );
> +  ASSERT_EFI_ERROR (Status);
> +}
> +
>  /**
>    Worker function to switch the requested AP to be the BSP from that point
> onward.
> 
> @@ -267,23 +311,9 @@ CpuFeaturesInitialize (
>    CpuFeaturesData->BspNumber = OldBspNumber;
> 
>    //
> -  // Known limitation: In PEI phase, CpuFeatures driver not
> -  // support async mode execute tasks. So semaphore type
> -  // register can't been used for this instance, must use
> -  // DXE type instance.
> -  //
> -
> -  if (CpuFeaturesData->NumberOfCpus > 1) {
> -    //
> -    // Wakeup all APs for programming.
> -    //
> -    StartupAPsWorker (SetProcessorRegister, NULL);
> -  }
> -
> -  //
> -  // Programming BSP
> +  // Start to program register for all CPUs.
>    //
> -  SetProcessorRegister (CpuFeaturesData);
> +  StartupCPUsWorker (SetProcessorRegister);
> 
>    //
>    // Switch to new BSP if required
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.in
> f
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.in
> f
> index 63091dfeb8..61f922bf63 100644
> ---
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.in
> f
> +++
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLi
> +++ b.inf
> @@ -46,6 +46,7 @@
> 
>  [Ppis]
>    gEfiPeiMpServicesPpiGuid                                             ## CONSUMES
> +  gEdkiiPeiMpServices2PpiGuid                                          ## CONSUMES
> 
>  [Pcd]
>    gUefiCpuPkgTokenSpaceGuid.PcdCpuS3DataAddress                        ##
> CONSUMES
> --
> 2.21.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44027): https://edk2.groups.io/g/devel/message/44027
Mute This Topic: https://groups.io/mt/32524461/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-