[edk2-devel] [PATCH 1/4] ArmPkg: list module-internal header files in INF [Sources]

[Laszlo Ersek]

The BaseTools build feature introduced for TianoCore#1804 / in commit
1fa6699e6cd4 ("BaseTools: Add a checking for Sources section in INF file",
2019-06-10) logs some (non-fatal) warnings about unlisted internal header
files. List those files explicitly.

Note: header files are added in lexicographical order only if the
underlying INF file already keeps the [Sources] and [LibraryClasses]
sections in lexicographical order. Otherwise, header files are added in
rough "logical" order.

Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org>
Cc: Leif Lindholm <leif.lindholm at linaro.org>
Signed-off-by: Laszlo Ersek <lersek at redhat.com>
---
 ArmPkg/Drivers/ArmGic/ArmGicDxe.inf                              | 1 +
 ArmPkg/Library/ArmLib/ArmBaseLib.inf                             | 3 +++
 ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
 3 files changed, 5 insertions(+)

diff --git a/ArmPkg/Drivers/ArmGic/ArmGicDxe.inf b/ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
index a1d027d84ad1..cd2cec248b5e 100644
--- a/ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
+++ b/ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
@@ -17,6 +17,7 @@ [Defines]
   ENTRY_POINT                    = InterruptDxeInitialize
 
 [Sources.common]
+  ArmGicDxe.h
   ArmGicDxe.c
   ArmGicCommonDxe.c
 
diff --git a/ArmPkg/Library/ArmLib/ArmBaseLib.inf b/ArmPkg/Library/ArmLib/ArmBaseLib.inf
index 669155688010..5e70990872f2 100644
--- a/ArmPkg/Library/ArmLib/ArmBaseLib.inf
+++ b/ArmPkg/Library/ArmLib/ArmBaseLib.inf
@@ -18,9 +18,11 @@ [Defines]
   LIBRARY_CLASS                  = ArmLib
 
 [Sources]
+  ArmLibPrivate.h
   ArmLib.c
 
 [Sources.ARM]
+  Arm/ArmV7Lib.h
   Arm/ArmV7Lib.c
 
   Arm/ArmLibSupport.S           | GCC
@@ -34,6 +36,7 @@ [Sources.ARM]
   Arm/ArmV7ArchTimerSupport.asm | RVCT
 
 [Sources.AARCH64]
+  AArch64/AArch64Lib.h
   AArch64/AArch64Lib.c
 
   AArch64/ArmLibSupport.S
diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
index 7724231ae96c..87c9b1150c54 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -26,6 +26,7 @@ [Defines]
 
 [Sources]
   PlatformBm.c
+  PlatformBm.h
 
 [Packages]
   EmbeddedPkg/EmbeddedPkg.dec
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44057): https://edk2.groups.io/g/devel/message/44057
Mute This Topic: https://groups.io/mt/32529015/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-