[edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources]

[Leif Lindholm]

On Wed, Jul 24, 2019 at 03:17:56PM +0000, Gao, Liming wrote:
> > Would it be feasible to update the --hash functionality to make use of
> > the include dependencies extracted from the source files? (Clearly, we
> > know when the source files change, so we would also know when we would
> > need to re-run the dependency search.)
> 
> The design is to save the step to extract the dependencies from the source files. 
> I can further collect the build performance to be taken on the dependencies extraction
> from the source files, and decide whether take this way. Another simple way is 
> to calculate all source files in module directory and make sure there is no file missing for --hash option.
> 
> > 
> > If not, I think we should make the explicit listing of .h files
> > in .inf mandatory, triggering a build failure when not the case.
> > 
> > If it is, then I think we should make it explicitly banned to list .h
> > files in .inf. (If there is no other dependency, such as doxygen, also
> > making use of .inf listings of .h files.)
> 
> I know edk2 also has PI Packaging UPT. PI packaging requires all source 
> files are listed in module INF file. Otherwise, some source files will be missed
> in the packaging, and can't be rollback.

OK, this means we should update the documentation to be crystal clear
that .h files need to be listed too.

I am OK to keep the warning enabled for now. But I would also wish
that we start planning for making it an error at some point in the
future.

Best Regards,

Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44323): https://edk2.groups.io/g/devel/message/44323
Mute This Topic: https://groups.io/mt/32529014/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-