[edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA

[Philippe Mathieu-Daudé]

On 7/24/19 11:44 PM, rebecca at bsdio.com wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.

Finally :)

Should we also update the wiki documentation?

Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>

> 
> Signed-off-by: Rebecca Cran <rebecca at bsdio.com>
> ---
>  OvmfPkg/build.sh | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 0219791aa8..960382f633 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -213,17 +213,6 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>        ENABLE_FLASH=yes
>        ;;
>    esac
> -
> -  ADD_QEMU_HDA=yes
> -  for arg in "$@"
> -  do
> -    case $arg in
> -      -hd[a-d]|-fd[ab]|-cdrom)
> -        ADD_QEMU_HDA=no
> -        break
> -        ;;
> -    esac
> -  done
>  fi
>  
>  #
> @@ -267,9 +256,6 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    else
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> -  if [[ "$ADD_QEMU_HDA" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -hda fat:$BUILD_ROOT_ARCH"
> -  fi
>    echo Running: $QEMU_COMMAND "$@"
>    $QEMU_COMMAND "$@"
>    exit $?
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44378): https://edk2.groups.io/g/devel/message/44378
Mute This Topic: https://groups.io/mt/32591949/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-