[edk2-devel] [PATCH edk2-platforms 2/4] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp

[Gary Lin]

On Fri, Jul 26, 2019 at 07:06:39AM +0000,  Gary Lin  wrote:
> BootManagerMenuApp wasn't imported so the Boot Device Menu never showed
> correctly.
> 
I should add more details for the fix below.

> Also fix the description of UiApp.
In the "Rule.Common.UEFI_APPLICATION.UI" section, it intends to change
the description of UiApp to "Enter Setup" to make the boot option
self-explaining in the Boot Menu. But this didn't happen since the rule
wasn't assigned to UiApp correctly, so the Boot Menu only showed "UiApp"
which is not understandable to users. This patch adds "RuleOverride = UI"
to UiApp.inf to change the description.


I'll add the above paragraph in case there is a v2 for this series.

Gary Lin

> Cc: Zailiang Sun <zailiang.sun at intel.com>
> Cc: Yi Qian <yi.qian at intel.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Signed-off-by: Gary Lin <glin at suse.com>
> ---
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf     | 3 ++-
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> index 48058b663a..55a309444f 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf
> @@ -417,7 +417,8 @@ INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf
>  INF MdeModulePkg/Universal/Metronome/Metronome.inf
>  INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>  INF MdeModulePkg/Logo/LogoDxe.inf
> -INF MdeModulePkg/Application/UiApp/UiApp.inf
> +INF RuleOverride = UI MdeModulePkg/Application/UiApp/UiApp.inf
> +INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
>  INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>  INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
>  INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 30b47d8f32..463b952e65 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -924,6 +924,7 @@
>        NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
>        NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
>    }
> +  MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
>
>    MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>    MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 57316d487b..ee18b45c97 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -939,6 +939,7 @@
>        NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
>        NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
>    }
> +  MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
>
>    MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>    MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
> -- 
> 2.22.0
> 
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44446): https://edk2.groups.io/g/devel/message/44446
Mute This Topic: https://groups.io/mt/32607134/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-