[edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

[Chiu, Chasel]

Yes, we will remove them later after confirming no impact to all platforms.

Regards,
Chasel


> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, July 30, 2019 11:46 AM
> To: Chiu, Chasel <chasel.chiu at intel.com>; devel at edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki at intel.com>; Sinha, Ankit
> <ankit.sinha at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>
> Subject: RE: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
> 
> Chasel:
>   This is a good enhancement. With this change, can
> RebaseAndPatchFspBinBaseAddress.py and PatchFspBinFvsBaseAddress.py be
> removed?
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: Chiu, Chasel
> > Sent: Monday, July 29, 2019 7:07 PM
> > To: devel at edk2.groups.io
> > Cc: Kubacki, Michael A <michael.a.kubacki at intel.com>; Sinha, Ankit
> > <ankit.sinha at intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone at intel.com>; Gao, Liming <liming.gao at intel.com>
> > Subject: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
> >
> > PcdFsp*BaseAddress now will be updated in FDF basing on flash map.
> > DSC will only define types of those PCDs and always having 0 as
> > default.
> > New script added to only rebase FSP binary without patching DSC file.
> >
> > Test: interanl platform booted with this patch.
> >
> > Cc: Michael Kubacki <michael.a.kubacki at intel.com>
> > Cc: Ankit Sinha <ankit.sinha at intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> > Cc: Liming Gao <liming.gao at intel.com>
> > Signed-off-by: Chasel Chiu <chasel.chiu at intel.com>
> >
> > Chasel Chiu (4):
> >   MinPlatformPkg: Auto configure Fsp*BaseAddress PCD
> >   Platform/Intel: Auto configure Fsp*BaseAddress PCD
> >   KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
> >   ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
> >
> >  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> |  3 +++
> >  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
> | 12 +++++++++---
> >  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
> |  3 +++
> >
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
> | 12 +++++++++---
> >  Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py   |
> 96
> >
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++
> >  Platform/Intel/build_bios.py                                         |  7 ++-----
> >  6 files changed, 122 insertions(+), 11 deletions(-)  create mode
> > 100644
> > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py
> >
> > --
> > 2.13.3.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44587): https://edk2.groups.io/g/devel/message/44587
Mute This Topic: https://groups.io/mt/32640908/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-