[edk2-devel] [edk2-platforms] [PATCH v2 5/6] Vlv2TbltDevicePkg: Add the missing SMBIOS bits

[Gary Lin]

fwupd 1.2.10 checks the bit 3 of BIOS Characteristics Extension Byte 2,
i.e. UefiSpecificationSupported, to determine if the system supports
UEFI or not. Since the bit was missing, fwupd failed to load uefi
plugin.

This commit adds 3 bits of BIOS Characteristics Extension Byte 2:
TargetContentDistributionEnabled, UefiSpecificationSupported, and
VirtualMachineSupported to complete the table.

Cc: Zailiang Sun <zailiang.sun at intel.com>
Cc: Yi Qian <yi.qian at intel.com>
Cc: Michael D Kinney <michael.d.kinney at intel.com>
Signed-off-by: Gary Lin <glin at suse.com>
---
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h     | 5 ++++-
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
index f57a5a8c0f..83749709ff 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h
@@ -1742,7 +1742,10 @@ typedef struct {
   UINT64                            SmartBatteryIsSupported           :1;
   UINT64                            BiosBootSpecIsSupported           :1;
   UINT64                            FunctionKeyNetworkBootIsSupported :1;
-  UINT64                            Reserved                          :22;
+  UINT64                            TargetContentDistributionEnabled  :1;
+  UINT64                            UefiSpecificationSupported        :1;
+  UINT64                            VirtualMachineSupported           :1;
+  UINT64                            Reserved                          :19;
 } EFI_MISC_BIOS_CHARACTERISTICS;
 
 typedef struct {
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
index 91e8efc228..f564e64d04 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBiosVendorData.c
@@ -87,7 +87,10 @@ MISC_SMBIOS_TABLE_DATA(EFI_MISC_BIOS_VENDOR_DATA, MiscBiosVendor)
 //
     1,    // BiosBootSpecIsSupported           :1
     1,    // FunctionKeyNetworkBootIsSupported :1
-    0x1     // Reserved                          :19  Bit 2 is SMBiosIsTargContDistEnabled
+    1,    // TargetContentDistributionEnabled  :1
+    1,    // UefiSpecificationSupported        :1
+    0,    // VirtualMachineSupported           :1
+    0     // Reserved                          :19
   },
   {       // BiosCharacteristics2
     0x0001,// BiosReserved                      :16  Bit 0 is BIOS Splash Screen
-- 
2.22.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44597): https://edk2.groups.io/g/devel/message/44597
Mute This Topic: https://groups.io/mt/32651921/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-