[edk2-devel] [PATCH v4 30/35] OvmfPkg/OvmfXen: Introduce XenTimerDxe
Laszlo Ersek
lersek at redhat.com
Tue Jul 30 12:30:41 UTC 2019
On 07/29/19 17:39, Anthony PERARD wrote:
> "OvmfPkg/8254TimerDxe" is replaced with a Xen-specific
> EFI_TIMER_ARCH_PROTOCOL implementation. Also remove
> 8259InterruptControllerDxe as it is not used anymore.
>
> This Timer uses the local APIC timer as time source as it can work on
> both a Xen PVH guest and an HVM one.
>
> Based on the "OvmfPkg/8254TimerDxe" implementation.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD <anthony.perard at citrix.com>
> Acked-by: Laszlo Ersek <lersek at redhat.com>
> ---
>
> Notes:
> v4:
> - fix the commit message to reflect the fact that the original code as
> moved.
> - Update Maintainers.txt
>
> v3:
> - rebased, SPDX, copyright
>
> v2:
> - Use InitializeApicTimer instead of WriteLocalApicReg
> - rework comments (remove many that don't apply)
> - remove unused includes, and libs
> - have a macro to the timervector.
> - cleanup, copyright
> - rework calculation of TimerCount, value to be use by the APIC timer
> - check for overflow of TimerPeriod, with the apic timer, the period can
> be up to about 42s on Xen (or even higher by changing the DivideValue).
>
> OvmfPkg/OvmfXen.dsc | 3 +-
> OvmfPkg/OvmfXen.fdf | 3 +-
> OvmfPkg/XenTimerDxe/XenTimerDxe.inf | 42 ++++
> OvmfPkg/XenTimerDxe/XenTimerDxe.h | 177 ++++++++++++++
> OvmfPkg/XenTimerDxe/XenTimerDxe.c | 355 ++++++++++++++++++++++++++++
> Maintainers.txt | 1 +
> 6 files changed, 577 insertions(+), 4 deletions(-)
> create mode 100644 OvmfPkg/XenTimerDxe/XenTimerDxe.inf
> create mode 100644 OvmfPkg/XenTimerDxe/XenTimerDxe.h
> create mode 100644 OvmfPkg/XenTimerDxe/XenTimerDxe.c
[...]
> diff --git a/Maintainers.txt b/Maintainers.txt
> index f51731a6b6..78e9f889ab 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -385,6 +385,7 @@ F: OvmfPkg/XenIoPciDxe/
> F: OvmfPkg/XenPlatformPei/
> F: OvmfPkg/XenPvBlkDxe/
> F: OvmfPkg/XenResetVector/
> +F: OvmfPkg/XenTimerDxe/
> R: Anthony Perard <anthony.perard at citrix.com>
> R: Julien Grall <julien.grall at arm.com>
>
>
Acked-by: Laszlo Ersek <lersek at redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44617): https://edk2.groups.io/g/devel/message/44617
Mute This Topic: https://groups.io/mt/32644086/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list