[edk2-devel] [PATCH edk2-platforms] Silicon/Marvell/EepromCmd: drop StdLib.dec reference

Leif Lindholm leif.lindholm at linaro.org
Thu May 2 16:16:09 UTC 2019


On Thu, May 02, 2019 at 01:00:13PM +0200, Ard Biesheuvel wrote:
> StdLib.dec has been move to a separate repository (edk2-libc), so
> any package that requires it needs to be built with an additional
> repo reference added to PACKAGES_PATH.
> 
> EepromCmd has such a reference, but since it doesn't appear to
> actually require it, let's just drop it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
>  Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> index c86ead1b7df2..77f76d51a647 100644
> --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.inf
> @@ -46,7 +46,6 @@ [Sources]
>  [Packages]
>    MdePkg/MdePkg.dec
>    ShellPkg/ShellPkg.dec
> -  StdLib/StdLib.dec
>    MdeModulePkg/MdeModulePkg.dec
>    Silicon/Marvell/Marvell.dec

I'm pretty sure there are unused LibraryClasses defined here and
headers included as well, but...
Reviewed-by: Leif Lindholm <leif.lindholm at linaro.org>

Marcin, can you give this command a quick scouring once you've sent
out the PCIe bits?
Certainly UefiRuntimeServicesTableLib is not used.

Regards,

Leif

>  
> -- 
> 2.20.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39923): https://edk2.groups.io/g/devel/message/39923
Mute This Topic: https://groups.io/mt/31453445/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list